[NFC] Escape an @ that throws spurious warnings #67021
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
beccadax
approved these changes
Jun 29, 2023
Contributor
beccadax
left a comment
beccadax
left a comment
There was a problem hiding this comment.
This isn’t worth rejecting the PR, but for future reference, we usually put [NFC] at the beginning of the message when a commit makes No Functional Changes (fixes comments or formatting, refactors without a behavior change, adds tests of existing behavior, etc.).
Otherwise LGTM.
JTurcotti
changed the title
etcwilde
approved these changes
Jun 29, 2023
Contributor
Author
|
thanks for the tip @beccadax ! modified PR message but next time will include in commit message too |
Contributor
Author
|
@swift-ci please merge |
Contributor
Author
|
@swift-ci please smoke test |
3 similar comments
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
addressed by #66915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This @ being unescaped throws a LOT of spurious warnings during build.