[Parser] Check let/var context when fix-it moving attributes from type to decl #65748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianoPAlmeida
requested review from
CodaFi,
DougGregor,
ahoppen,
bnbarham and
rintaro
as code owners
Contributor
Author
|
@swift-ci Please test |
ahoppen
reviewed
May 8, 2023
LucianoPAlmeida
force-pushed
the
parse-attr-fix-it
branch
from
30ab30f to
109b785
Compare
ahoppen
approved these changes
May 9, 2023
Member
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please smoke test MacOS platform |
Contributor
Author
|
@swift-ci Please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small diagnostic QOI one
When in a declaration, the fix-it to move the attribute cannot be applied in all cases. So doing extra checks to be more conservative and add a couple of more test for this.
Resolves #65705