[5.9][CSSyntaticElement] Desugar types before collecting "in scope" type v… #65049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariables Generic type aliases, unless desugared, could bring unrelated type variables into the scope i.e. `TypeAlias<$T, $U>.Context` is actually `_Context<$U>`. These variables could be inferrable only after the the body the closure is solved. To avoid that, let's adjust `TypeVariableRefFinder` to desugar types before collecting referenced type variables. Resolves: rdar://107835060 (cherry picked from commit ca14ab7)
Contributor
Author
|
@swift-ci please test |
hborla
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ariables
Cherry-pick of #65048
Generic type aliases, unless desugared, could bring unrelated type variables into the scope i.e.
TypeAlias<$T, $U>.Contextis actually_Context<$U>. These variables could be inferrable only after the the body the closure is solved. To avoid that, let's adjustTypeVariableRefFinderto desugar types before collecting referenced type variables.Scope: Calls with multi-statement closures that get contextual parameters/result types that use generic type aliases.
Main Branch PR: [CSSyntaticElement] Desugar types before collecting "in scope" type v… #65048
Resolves: rdar://107835060
Risk: Low
Reviewed By: @hborla
Testing: Added a regression test-case to the suite.
Resolves: rdar://107835060
(cherry picked from commit ca14ab7)