[AddressLowering] Don't end_borrow trivial args. #62198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same functionality that already exists in the performance inliner.
When loading an argument, first check whether its type is trivial. If so, produce a `load [trivial]`. Only then produce `load [take]`s or `load_borrow`s. Fixes an issue where values passed @in_guaranteed were `load [trivial]`'d and then `end_borrow`'d.
nate-chandler
force-pushed
the
opaque-values/3/20221118
branch
from
c847805 to
dbda1bf
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS platform |
Contributor
Author
|
@swift-ci please clean test macOS platform |
Contributor
Author
|
@swift-ci please test and merge |
atrick
approved these changes
Nov 29, 2022
Contributor
atrick
left a comment
atrick
left a comment
There was a problem hiding this comment.
Thanks. Incidentally, the emitLoadBorrow/emitEndBorrow helpers are supposed to do this for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading an argument, first check whether its type is trivial. If so, produce a
load [trivial]. Only then produceload [take]s orload_borrows. Fixes an issue where values passed @in_guaranteed wereload [trivial]'d and thenend_borrow'd.Also added the inlining logging used in the performance inliner to the mandatory inliner. It was used to track down this issue.