Delete libSyntax #62145
Merged
Delete libSyntax #62145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
requested review from
DougGregor,
ahoppen,
bnbarham and
rintaro
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test source compatibility |
Member
|
@swift-ci please build toolchain windows platform |
Expand it to llvm::IntrusiveRefCntPtr
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci please build toolchain windows platform |
Contributor
Author
|
@swift-ci test source compatibility |
Contributor
Author
|
swiftlang/llvm-project#5630 |
Contributor
Author
|
@swift-ci test |
Collaborator
|
Is this inadvertently conflicting with #62132? |
Contributor
Author
|
swiftlang/swift-syntax#1084 |
Contributor
Author
|
@AnthonyLatsis @rintaro I suspect I’m going to win this race 😉. |
Collaborator
😅
|
This was referenced Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that swift-syntax no longer consumes the serialized parse tree (see swiftlang/swift-syntax#1041), and we are no longer building the internal swift-syntax dylib (see #61898), we are finally able to get rid of the C++ libSyntax library.
Delete libSyntax, the tests dependent upon it, and redistribute some of the remaining useful types it defined to other parts of the compiler.