ABISafeConversionComponent should be a TranslationComponent #61029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er than physical Also renaming it to be UncheckedConversionComponent since it's a better name. As a physical component, we'd run into problems in assignment statements. The problem was that if we had something like: ``` SomeOtherComponent // first component GetterSetterComponent ABISafeConversionComponent // last component ``` When emitting the assignment, we always drill down through all but the last component by calling `project()` on each one. Then on the last component, we'd do the actual setting operation. But GetterSetterComponent cannot be projected when the access is for writing. So, to work around this I decided to model it as a TranslationComponent, because those are specifically designed to be handled during an assignment by popping those off the end of the component sequence, untranslating the value we're about to assign as we go, until we hit the GetterSetterComponent. By "untranslating" we're effectively putting Sendable back onto the set's argument prior to calling set, because the underlying property's type still has `@Sendable` on it (e.g., it's accessors still have that on its argument type). When "translating" we're effectively taking Sendable off after reading it. I think actually works really well and makes much more sense now. resolves rdar://99619834
kavon
force-pushed
the
assign-preconcurrency-followup-logicalAttempt
branch
from
b6f1db0 to
42f82f8
Compare
kavon
force-pushed
the
assign-preconcurrency-followup-logicalAttempt
branch
from
42f82f8 to
bcc7541
Compare
Member
Author
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon / fixes #60521
Also renaming it to be UncheckedConversionComponent since it's a better name.
As a physical component, we'd run into problems in assignment statements.
The problem was that if we had something like:
When emitting the assignment, we always drill down through all but
the last component by calling
project()on each one. Then on the lastcomponent, we'd do the actual setting operation. But GetterSetterComponent
cannot be projected when the access is for writing.
So, to work around this I decided to model it as a TranslationComponent, because
those are specifically designed to be handled during an assignment by popping those
off the end of the component sequence, untranslating the value we're about to assign
as we go, until we hit the GetterSetterComponent.
By "untranslating" we're effectively putting Sendable back onto the set's argument
prior to calling set, because the underlying property's type still has
@Sendableon it (e.g., it's accessors still have that on its argument type). When
"translating" we're effectively taking Sendable off after reading it.
I think actually works really well and makes much more sense now.
resolves rdar://99619834