Skip to content

Default to building the early SwiftSyntax package. #60815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2022
Merged

Default to building the early SwiftSyntax package. #60815

merged 1 commit into from
Sep 20, 2022

Conversation

@DougGregor
Copy link
Member

@DougGregor DougGregor commented Aug 27, 2022 •
edited
Loading

Switch the polarity for early SwiftSyntax to build it by default (and embed it into Swift tools). One can use build-script --skip-early-swiftsyntax to disable this.

@DougGregor
Copy link
Member Author

DougGregor commented Aug 27, 2022

swiftlang/swift-syntax#646

@swift-ci please test

@DougGregor
Copy link
Member Author

DougGregor commented Aug 27, 2022

The failure here is because we're using implicit opening of existentials, but that's only supported in Swift 5.7 and newer. Trying to address this via swiftlang/swift-syntax#648

@DougGregor
Copy link
Member Author

DougGregor commented Aug 27, 2022

@swift-ci please test

@DougGregor
Copy link
Member Author

DougGregor commented Aug 28, 2022

Well, the good news is that earlyswiftsyntax built for macOS. Linux looks like it skipped building it, and there are some failures remaining that need investigation:

Swift-validation(macosx-x86_64) :: BuildSystem/core_lipo_and_non_core_epilogue_opts.test
Swift-validation(macosx-x86_64) :: BuildSystem/default_build_still_performs_epilogue_opts_after_split.test
Swift-validation(macosx-x86_64) :: BuildSystem/infer_dumps_deps_if_verbose_build.test
Swift-validation(macosx-x86_64) :: BuildSystem/infer_implies_install_all.test
Swift-validation(macosx-x86_64) :: BuildSystem/test_early_swift_driver_and_infer.swift

@DougGregor DougGregor force-pushed the default-build-early-swiftsyntax branch from f732af1 to fbb0f67 Compare September 9, 2022 17:52
@DougGregor
Copy link
Member Author

DougGregor commented Sep 9, 2022

@swift-ci please test

@DougGregor DougGregor force-pushed the default-build-early-swiftsyntax branch from fbb0f67 to 6545830 Compare September 14, 2022 23:21
@DougGregor
Copy link
Member Author

DougGregor commented Sep 14, 2022

swiftlang/llvm-project#5289

@swift-ci please test

1 similar comment
@DougGregor
Copy link
Member Author

DougGregor commented Sep 16, 2022

swiftlang/llvm-project#5289

@swift-ci please test

@DougGregor
Copy link
Member Author

DougGregor commented Sep 16, 2022

macOS failures:

Failed Tests (2):
  Swift-Unit :: DependencyScan/./swiftScanTests/failed_to_discover_tests_from_gtest
  Swift-validation(macosx-x86_64) :: Python/python_lint.swift

@DougGregor DougGregor force-pushed the default-build-early-swiftsyntax branch from 6545830 to 11bcb61 Compare September 17, 2022 05:23
@DougGregor
Copy link
Member Author

DougGregor commented Sep 17, 2022

@swift-ci please test

@DougGregor DougGregor marked this pull request as ready for review September 17, 2022 05:24
@DougGregor
Copy link
Member Author

DougGregor commented Sep 17, 2022

swiftlang/llvm-project#5322

@swift-ci please test

@DougGregor
Default to building the early SwiftSyntax package.
de35614 
One can disable this with `build-script --skip-early-swiftsyntax`.
@DougGregor DougGregor force-pushed the default-build-early-swiftsyntax branch from 11bcb61 to de35614 Compare September 18, 2022 21:33
@DougGregor
Copy link
Member Author

DougGregor commented Sep 18, 2022

@swift-ci please test

1 similar comment
@DougGregor
Copy link
Member Author

DougGregor commented Sep 19, 2022

@swift-ci please test

@DougGregor DougGregor merged commit b3c1339 into swiftlang:main Sep 20, 2022
@DougGregor DougGregor deleted the default-build-early-swiftsyntax branch September 20, 2022 00:58
@DougGregor DougGregor mentioned this pull request Sep 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kingzooz kingzooz kingzooz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DougGregor @kingzooz