Fix reflection subclassing #5831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment attributes This attribute is used in the simd overlay. To ensure we can layout SIMD types correctly, emit a fixed type descriptor instead of a field type descriptor for these types.
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
There were a few problems here with subclasses of Objective-C classes. Use the InstanceStart field from rodata to correctly lay out instance variables, and verify the results match with dynamic and static layout. Better fix for <rdar://problem/27932061>.
slavapestov
force-pushed
the
fix-reflection-subclassing
branch
from
77ad5bf to
1c7a50d
Compare
Contributor
Author
|
@swift-ci Please test |
1 similar comment
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.