[Type checker] Eliminate generation of useless constraints NFC. #5261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no point in adding the constraints known on an associated type to the constraint system, because they're implied by the protocol constraint itself.
Member
Author
|
@swift-ci please smoke test and merge |
With the previous type-checker change, we end up with some vacuous infix operator completions, where the right-hand side and result type are *both* type variables. Suppress these; they aren't useful to the developer.
Member
Author
|
@swift-ci please smoke test and merge |
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 7, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no point in adding the constraints known on an associated type
to the constraint system, because they're implied by the protocol
constraint itself.