[lit] Rename config.targets_to_build => config.llvm_targets and allow… #3577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test and merge |
Contributor
|
I believe you'll need to make this same change in |
gottesmm
force-pushed
the
lit_make_config_llvm_targets_actually_work
branch
from
c35fafb to
103be3f
Compare
Contributor
Author
|
@modocache I just forgot about it ; ) |
Contributor
Author
|
@swift-ci Please smoke test and merge |
…r run on any platforms.
…nd allow it to actually take on a value. Previously this variable was always just "". Now using the recent cmake changes that I made, we can just grab the proper values from LLVMConfig.cmake. I need this so that we can REQUIRES tests based on the code generators that LLVM was compiled with. To make it easy to show the dependency in the requires line, the requires pattern to use is: REQUIRES: CODEGENERATOR=...
gottesmm
force-pushed
the
lit_make_config_llvm_targets_actually_work
branch
from
103be3f to
aa708ea
Compare
Contributor
Author
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
… it to actually take on a value.
Previously this variable was always just "". Now we can grab the proper value
from LLVMConfig.cmake (given the recent cmake changes I made).
I need this so that we can REQUIRES tests based on the code generators that LLVM
was compiled with.