Skip to content

Conversation

@benrimmington
Copy link
Contributor

Most of the changes are simple renames:

  • UTF8Unicode.UTF8
  • UTF16Unicode.UTF16
  • UTF32Unicode.UTF32
  • UnicodeScalarUnicode.Scalar
  • UnicodeCodecUnicode.Encoding

Follow-up to: #32920

@benrimmington
Copy link
Contributor Author

@swift-ci Please smoke test

@benrimmington
Copy link
Contributor Author

@swift-ci Please smoke benchmark

@swift-ci
Copy link
Contributor

Performance: -O

Regression OLD NEW DELTA RATIO
String.data.Medium 85 96 +12.9% 0.89x (?)
ObjectiveCBridgeStubToNSDate2 490 550 +12.2% 0.89x (?)
 
Improvement OLD NEW DELTA RATIO
FlattenListFlatMap 5600 4210 -24.8% 1.33x (?)

Code size: -O

Performance: -Osize

Improvement OLD NEW DELTA RATIO
DataReplaceMedium 4000 3700 -7.5% 1.08x (?)

Code size: -Osize

Performance: -Onone

Improvement OLD NEW DELTA RATIO
ObjectiveCBridgeStubToNSDate2 650 560 -13.8% 1.16x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 8-Core Intel Xeon E5
  Processor Speed: 3 GHz
  Number of Processors: 1
  Total Number of Cores: 8
  L2 Cache (per Core): 256 KB
  L3 Cache: 25 MB
  Memory: 64 GB

@benrimmington
Copy link
Contributor Author

@milseman This pull request uses the new names, but it doesn't deprecate the old ones.

Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify what your goal is? This doesn't seem like an improvement to the readability of stdlib code.

@benrimmington benrimmington deleted the se-0163-migration-2 branch August 7, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants