[AutoDiff] Serialize and print @derivative and @transpose accessor kind.
#32839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r kind. Serialize and print the optional accessor kind in `@derivative` and `@transpose` attributes. Resolves TF-1293.
dan-zheng
commented
Jul 11, 2020
Comment on lines
+59
to
+63
| // Note: qualified name base types are not yet serialized and are not printed | ||
| // when round-tripping. | ||
|
|
||
| // CHECK: @derivative(of: instanceMethod, wrt: (self, x)) | ||
| @derivative(of: instanceMethod, wrt: (self, x)) | ||
| @derivative(of: S.instanceMethod, wrt: (self, x)) |
Contributor
Author
There was a problem hiding this comment.
Note: qualified name base types are not yet serialized for @derivative or @transpose attributes.
Example: @derivative(of: S.instanceMethod) is serialized and subsequently printed as @derivative(of: instanceMethod).
This isn't yet an issue in practice, because @derivative and @transpose declarations are designed to be declared in the same type context as their referenced original declaration. We can tackle it if it becomes a problem.
Contributor
Author
|
@swift-ci Please smoke test |
rxwei
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize and print the optional accessor kind in
@derivativeand@transposeattributes.Example:
@derivative(of: property.set)is now serialized and printed as@derivative(of: property.set)instead of@derivative(of: property).Resolves TF-1293.