Skip to content

[Runtime] Add entry point to compare conformance descriptors. #32471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

[Runtime] Add entry point to compare conformance descriptors. #32471

merged 1 commit into from
Jun 23, 2020

Conversation

@nate-chandler
Copy link
Contributor

@nate-chandler nate-chandler commented Jun 19, 2020

The new function swift_compareProtocolConformanceDescriptors just calls through to the preexisting code in MetadataCacheKey which has been extracted out from MetadataCacheKey::compareWitnessTables into a new public static function MetadataCacheKey::compareProtocolConformanceDescriptors.

The new function's availability is Swift Future for now.

@nate-chandler
Copy link
Contributor Author

nate-chandler commented Jun 19, 2020

@swift-ci please test

@nate-chandler nate-chandler changed the title [Runtime] Added entry point to compare conformance descriptors. [Runtime] Add entry point to compare conformance descriptors. Jun 19, 2020
@nate-chandler nate-chandler force-pushed the runtime/add-swift_compareProtocolConformanceDescriptors branch 2 times, most recently from cfb4db2 to dc67a84 Compare June 19, 2020 19:00
@nate-chandler
Copy link
Contributor Author

nate-chandler commented Jun 19, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 19, 2020

Build failed
Swift Test Linux Platform
Git Sha - 385552b192454c8add79b7022d794b15029c0564

@swift-ci
Copy link
Contributor

swift-ci commented Jun 19, 2020

Build failed
Swift Test OS X Platform
Git Sha - 385552b192454c8add79b7022d794b15029c0564

@nate-chandler nate-chandler force-pushed the runtime/add-swift_compareProtocolConformanceDescriptors branch from dc67a84 to 2cc7c55 Compare June 19, 2020 19:17
@nate-chandler
Copy link
Contributor Author

nate-chandler commented Jun 19, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 19, 2020

Build failed
Swift Test Linux Platform
Git Sha - dc67a844e8cf61b1f636eb851d8c7e7ff229a780

@swift-ci
Copy link
Contributor

swift-ci commented Jun 19, 2020

Build failed
Swift Test OS X Platform
Git Sha - dc67a844e8cf61b1f636eb851d8c7e7ff229a780

@nate-chandler nate-chandler force-pushed the runtime/add-swift_compareProtocolConformanceDescriptors branch from 2cc7c55 to ed23370 Compare June 20, 2020 00:23
@nate-chandler
Copy link
Contributor Author

nate-chandler commented Jun 20, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jun 20, 2020

Build failed
Swift Test OS X Platform
Git Sha - 2cc7c55c286ab195fe6314b6c308035942bc31cb

@swift-ci
Copy link
Contributor

swift-ci commented Jun 20, 2020

Build failed
Swift Test Linux Platform
Git Sha - 2cc7c55c286ab195fe6314b6c308035942bc31cb

@nate-chandler
Copy link
Contributor Author

nate-chandler commented Jun 20, 2020

@swift-ci please clean test os x platform

@nate-chandler nate-chandler mentioned this pull request Jun 20, 2020
Merged
@swift-ci
Copy link
Contributor

swift-ci commented Jun 20, 2020

Build failed
Swift Test OS X Platform
Git Sha - ed23370494bcc996fb3e49a1d7ea7f8640717aeb

@nate-chandler
Copy link
Contributor Author

nate-chandler commented Jun 22, 2020

@swift-ci please clean test os x platform

@nate-chandler nate-chandler force-pushed the runtime/add-swift_compareProtocolConformanceDescriptors branch from ed23370 to 575facd Compare June 22, 2020 19:34
@nate-chandler
Copy link
Contributor Author

nate-chandler commented Jun 22, 2020

@swift-ci please smoke test and merge

@nate-chandler nate-chandler force-pushed the runtime/add-swift_compareProtocolConformanceDescriptors branch from 575facd to be56d6f Compare June 22, 2020 21:56
@nate-chandler
[Runtime] Add entry point to compare conformance descriptors.
6d0c34c 
The new function swift_compareProtocolConformanceDescriptors calls
through to the preexisting code in MetadataCacheKey which has been
extracted out from MetadataCacheKey::compareWitnessTables into a new
public static function
MetadataCacheKey::compareProtocolConformanceDescriptors.

The new function's availability is "future" for now.
@nate-chandler nate-chandler force-pushed the runtime/add-swift_compareProtocolConformanceDescriptors branch from be56d6f to 6d0c34c Compare June 22, 2020 22:01
@nate-chandler
Copy link
Contributor Author

nate-chandler commented Jun 22, 2020

@swift-ci please smoke test and merge

1 similar comment
@nate-chandler
Copy link
Contributor Author

nate-chandler commented Jun 22, 2020

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 236237f into swiftlang:master Jun 23, 2020
@nate-chandler nate-chandler deleted the runtime/add-swift_compareProtocolConformanceDescriptors branch July 5, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nate-chandler @swift-ci