Skip to content

[CodeCompletion] Fix non-determinisc failures in dependency check test cases #32030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

[CodeCompletion] Fix non-determinisc failures in dependency check test cases #32030

merged 1 commit into from
May 28, 2020

Conversation

@rintaro
Copy link
Member

@rintaro rintaro commented May 26, 2020 •
edited
Loading

Sleep a few seconds to ensure the timestamps of the modified files are different from the last completion.

rdar://problem/62923248

@rintaro
Copy link
Member Author

rintaro commented May 26, 2020

@swift-ci Please test

@rintaro rintaro requested a review from akyrtzi May 26, 2020 22:55
@rintaro rintaro changed the title [CodeCompletion] Fix determinisc failures in dependency check test cases [CodeCompletion] Fix non-determinisc failures in dependency check test cases May 26, 2020
@swift-ci
Copy link
Contributor

swift-ci commented May 27, 2020

Build failed
Swift Test Linux Platform
Git Sha - 8c6796a889b966515e2e89182d4ac8f4582a4c35

akyrtzi
akyrtzi reviewed May 27, 2020
View reviewed changes
test/SourceKit/CodeComplete/complete_checkdeps_bridged.swift Outdated
Copy link
Contributor

@akyrtzi akyrtzi May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the second sleep really needed?

Copy link
Member Author

@rintaro rintaro May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's not needed, but just I wanted to be on the safe side.

Copy link
Contributor

@akyrtzi akyrtzi May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we try removing it, it's better if we don't make tests unnecessarily slower.

@rintaro
Copy link
Member Author

rintaro commented May 27, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented May 27, 2020

Build failed
Swift Test Linux Platform
Git Sha - 8c6796a889b966515e2e89182d4ac8f4582a4c35

@rintaro
[CodeCompletion] Fix non-determinisc failures in dependency check tes…
ad51f4f 
…t cases

Sleep a few seconds to ensure the timestamp of the modified files are
different from the last completion.

rdar://problem/62923248
@rintaro rintaro force-pushed the ide-completion-rdar62923248 branch from 8c6796a to ad51f4f Compare May 27, 2020 15:58
@rintaro
Copy link
Member Author

rintaro commented May 27, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented May 27, 2020

Build failed
Swift Test Linux Platform
Git Sha - 8c6796a889b966515e2e89182d4ac8f4582a4c35

@swift-ci
Copy link
Contributor

swift-ci commented May 27, 2020

Build failed
Swift Test OS X Platform
Git Sha - 8c6796a889b966515e2e89182d4ac8f4582a4c35

@rintaro
Copy link
Member Author

rintaro commented May 27, 2020

@swift-ci Please test Linux

@swift-ci
Copy link
Contributor

swift-ci commented May 27, 2020

Build failed
Swift Test Linux Platform
Git Sha - ad51f4f

@rintaro
Copy link
Member Author

rintaro commented May 27, 2020

@swift-ci Please smoke test Linux

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented May 28, 2020

@swift-ci Please smoke test Linux

@rintaro rintaro merged commit 45a78e4 into swiftlang:master May 28, 2020
@rintaro rintaro mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rintaro @swift-ci @akyrtzi