Skip to content

[DNM] IRGen tests #31981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2020
Merged

[DNM] IRGen tests #31981

merged 2 commits into from
May 23, 2020

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented May 22, 2020

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

davezarzycki and others added 2 commits May 22, 2020 09:21
@davezarzycki @compnerd
Remove three ObjC fields from non-ObjC runtime
97c89d8
@compnerd
test: account for indirect imports
2c17600 
Adjust the test to accommodate environments which do indirect imports,
which use the singleton strategy, relying on the runtime initialization
of fields which are imported.
@compnerd
Copy link
Member Author

compnerd commented May 22, 2020

@swift-ci please test

@compnerd compnerd changed the title IRGen tests [DNM] IRGen tests May 22, 2020
@compnerd compnerd mentioned this pull request May 22, 2020
Merged
@swift-ci
Copy link
Contributor

swift-ci commented May 22, 2020

Build failed
Swift Test Linux Platform
Git Sha - 2c17600

@davezarzycki
Copy link
Contributor

davezarzycki commented May 23, 2020

I've reset #31811 to this commit, so either retesting #31811 with CI will "just work" or having two pull requests with the same commit hash will cause CI to crawl into a corner and die. We'll see! Thank you @compnerd for doing the work :-)

@compnerd
Copy link
Member Author

compnerd commented May 23, 2020

You're welcome!

@compnerd compnerd merged commit 435b239 into swiftlang:master May 23, 2020
@compnerd compnerd deleted the objc-import-tests branch May 23, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@compnerd @swift-ci @davezarzycki