Skip to content

Use a faster test for LLVMFuzzerTestOneInput #31842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2020
Merged

Use a faster test for LLVMFuzzerTestOneInput #31842

merged 1 commit into from
May 17, 2020

Conversation

@benrimmington
Copy link
Contributor

@benrimmington benrimmington commented May 16, 2020

  • The old test ("ABC" only) usually takes several minutes.
  • The new test (hex-digits) usually takes one second.

Follow-up to: #31802

@benrimmington
Copy link
Contributor Author

benrimmington commented May 16, 2020

Cc: @harlanhaskins, @CodaFi

@harlanhaskins
Copy link
Contributor

harlanhaskins commented May 16, 2020

Good call! Thanks!

@harlanhaskins
Copy link
Contributor

harlanhaskins commented May 16, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented May 16, 2020

Build failed
Swift Test OS X Platform
Git Sha - ce03401

@CodaFi
Copy link
Contributor

CodaFi commented May 16, 2020

@swift-ci smoke test macOS platform

@CodaFi
Copy link
Contributor

CodaFi commented May 16, 2020

@swift-ci smoke test Windows

@benrimmington
Copy link
Contributor Author

benrimmington commented May 16, 2020

@CodaFi I think the iOS and Windows failures will be fixed when #31843 is merged.

@compnerd
Copy link
Member

compnerd commented May 16, 2020

@swift-ci please test macOS platform

@compnerd
Copy link
Member

compnerd commented May 16, 2020

@swift-ci please test windows platform

@benrimmington
Copy link
Contributor Author

benrimmington commented May 17, 2020

All checks have passed.

Sanitizers/fuzzer.swift is no longer listed under "Slowest Tests".

@harlanhaskins harlanhaskins merged commit d67638a into swiftlang:master May 17, 2020
@benrimmington benrimmington deleted the llvm-fuzzer-test-one-input branch May 17, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harlanhaskins harlanhaskins harlanhaskins approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benrimmington @harlanhaskins @swift-ci @CodaFi @compnerd