[build] Set language flag for C++ on OpenBSD. #31057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See swiftlang#12510 and SR-3635 for some context; OpenBSD exhibits the same problem listed here. Without this, the build fails with an undefined symbol error for __gnustep_objcxx_personality_v0. Per commentary on the aforementioned PR, forcing the language to be interpreted as C++ solves the problem. There might be something different we can do here to diagnose and fix this, but this is the simplest solution to get the build working and enabling this for all C++ files should be tautologous and therefore harmless.
3405691582
force-pushed
the
OpenBSD_Port_CppIsCpp
branch
from
dba104a to
1f0550f
Compare
Contributor
|
@swift-ci test |
Contributor
|
Sorry about that. Fat-fingered shift. |
Contributor
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12510 and SR-3635 for some context; OpenBSD exhibits the same
problem listed here. Without this, the build fails with an undefined
symbol error for __gnustep_objcxx_personality_v0. Per commentary on the
aforementioned PR, forcing the language to be interpreted as C++ solves
the problem.
There might be something different we can do here to diagnose and fix
this, but this is the simplest solution to get the build working again,
and enabling this for all C++ files should be tautologous and therefore
harmless.