[AutoDiff upstream] DifferentiationUnittest and some e2e tests #30915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Note: depends on #30909 for tests to pass, so there's no point running tests before that gets merged. |
dan-zheng
approved these changes
Apr 9, 2020
Contributor
dan-zheng
left a comment
dan-zheng
left a comment
There was a problem hiding this comment.
Exciting that tests pass!
dan-zheng
reviewed
Apr 9, 2020
rxwei
approved these changes
Apr 9, 2020
dan-zheng
reviewed
Apr 9, 2020
marcrasi
force-pushed
the
ad-upstream-tests-2
branch
from
770d430 to
4e3eea1
Compare
marcrasi
commented
Apr 9, 2020
stdlib/private/CMakeLists.txt
Outdated
Author
There was a problem hiding this comment.
Oh, does this need if(SWIFT_ENABLE_EXPERIMENTAL_DIFFERENTIABLE_PROGRAMMING)? I'll add that here and see what happens.
marcrasi
force-pushed
the
ad-upstream-tests-2
branch
from
4e3eea1 to
3857192
Compare
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
Adds 2 simple e2e tests and some lit subsitutions and unittest libraries necessary to support them.
marcrasi
force-pushed
the
ad-upstream-tests-2
branch
from
3857192 to
43ca015
Compare
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Author
|
@swift-ci please test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 simple e2e tests and some lit subsitutions and unittest libraries
necessary to support them.