Skip to content

Remove build-script-impl target calculation #26495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2019
Merged

Remove build-script-impl target calculation #26495

merged 1 commit into from
Nov 16, 2019

Conversation

@porglezomp
Copy link
Contributor

@porglezomp porglezomp commented Aug 5, 2019

This removes some code that was duplicated between build-script and build-script-impl. It was duplicated between these for migration purposes, but isn't needed for that purpose anymore.

@porglezomp
Remove build-script-impl target calculation
b059fd5 
It's duplicated between the build-script and the -impl, removing code
from build-script-impl is good.
@Rostepher
Copy link
Contributor

Rostepher commented Aug 5, 2019

Assuming this passes testing I'm all for getting rid of this cruft.

@Rostepher
Copy link
Contributor

Rostepher commented Aug 5, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Aug 5, 2019

Build failed
Swift Test Linux Platform
Git Sha - b059fd5

@harlanhaskins
Copy link
Contributor

harlanhaskins commented Aug 5, 2019

@swift-ci please test Linux

@swift-ci
Copy link
Contributor

swift-ci commented Aug 5, 2019

Build failed
Swift Test Linux Platform
Git Sha - b059fd5

@compnerd
Copy link
Member

compnerd commented Aug 6, 2019

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Aug 6, 2019

Build failed
Swift Test Linux Platform
Git Sha - b059fd5

@compnerd
Copy link
Member

compnerd commented Aug 6, 2019

Seems that IndexStoreDB is unhappy:

11:45:33 
/home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/indexstore-db/Tests/ISDBTibsTests/TibsBuildTests.swift:97: error: TibsBuildTests.testBuildMixedLang : XCTAssertEqual failed: ("["\'/home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/tmp/TibsBuildTests.testBuildMixedLang/src/b.c\'", "\'/home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/tmp/TibsBuildTests.testBuildMixedLang/src/e.mm\'", "\'/home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/tmp/TibsBuildTests.testBuildMixedLang/src/c.m\'", "\'/home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/tmp/TibsBuildTests.testBuildMixedLang/src/d.cpp\'", "Swift Module main"]") is not equal to ("["/home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/tmp/TibsBuildTests.testBuildMixedLang/src/c.m", "/home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/tmp/TibsBuildTests.testBuildMixedLang/src/d.cpp", "/home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/tmp/TibsBuildTests.testBuildMixedLang/src/b.c", "/home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/tmp/TibsBuildTests.testBuildMixedLang/src/e.mm", "Swift Module main"]") -

@compnerd
Copy link
Member

compnerd commented Nov 16, 2019

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Nov 16, 2019

Build failed
Swift Test Linux Platform
Git Sha - b059fd5

@compnerd
Copy link
Member

compnerd commented Nov 16, 2019

@swift-ci please test Linux platform

@compnerd compnerd merged commit 3932133 into swiftlang:master Nov 16, 2019
@finagolfin finagolfin mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rostepher Rostepher Rostepher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@porglezomp @Rostepher @swift-ci @harlanhaskins @compnerd