[QoI] make several improvements to the unused expression diagnostics,… #2559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to go along with recent policy changes: - For expression types that are not specifically handled, make sure to produce a general "unused value" warning, catching a bunch of unused values in the testsuite. - For unused operator results, diagnose them as uses of the operator instead of "calls". - For calls, mutter the type of the result for greater specificity. - For initializers, mutter the type of the initialized value. - Look through OpenExistentialExpr's so we can handle protocol member references propertly. - Look through several other expressions so we handle @discardableResult better.
Member
Author
|
@swift-ci test |
Member
Author
|
Some test failures: @lattner Is there another commit I need to pull in? |
Contributor
|
@tkremenek Yes, 05397e3. |
…tarted produced more warnings
Member
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in 3549ec5 from
master.