[CodeCompletion] Infer keypath root type from the context type #23542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
ide-completion-keypathcontext-rdar46102807
branch
from
5d8bed6 to
463c3d4
Compare
Member
Author
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Mar 25, 2019
Contributor
benlangmuir
left a comment
benlangmuir
left a comment
There was a problem hiding this comment.
LGTM; one typo in comment.
lib/IDE/CodeCompletion.cpp
Outdated
Contributor
There was a problem hiding this comment.
typo: keypat -> keypath
So that this works:
```
func foo(_: KeyPath<SomeObject, Int>) {}
foo(\.<HERE>)
```
rdar://problem/46102807
rintaro
force-pushed
the
ide-completion-keypathcontext-rdar46102807
branch
from
463c3d4 to
65d8d29
Compare
Member
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that this works:
rdar://problem/46102807