Skip to content

Conversation

@huonw
Copy link
Contributor

@huonw huonw commented May 11, 2018

rdar://problem/40150393

@huonw
Copy link
Contributor Author

huonw commented May 11, 2018

@swift-ci please smoke test

@huonw huonw requested review from airspeedswift and lorentey May 11, 2018 02:26
@huonw
Copy link
Contributor Author

huonw commented May 11, 2018

@airspeedswift and/or @lorentey is this the recommended way to check for Float80?

@jrose-apple
Copy link
Contributor

Or @stephentyrone?

@airspeedswift
Copy link
Member

That's certainly how we're doing it in the main floating point tests: https://github.com/apple/swift/blob/master/test/stdlib/FloatingPoint.swift.gyb#L417

@huonw huonw merged commit 6015709 into swiftlang:master May 11, 2018
@huonw
Copy link
Contributor Author

huonw commented May 11, 2018

Thanks.

@huonw huonw deleted the conditionalize-float80 branch May 11, 2018 03:14
@stephentyrone
Copy link
Contributor

Just to confirm, even though this is already merged: LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants