From e860994b2769729442d2c5b187de53b9c5edad21 Mon Sep 17 00:00:00 2001 From: Bob Wilson Date: Thu, 3 May 2018 16:59:45 -0700 Subject: [PATCH] Reenable Runtime/linux-fatal-backtrace.swift test This test broke when we switched to the swift-4.2-branch of Clang/LLVM. It seems to be a problem with LLDB's CreateTargetWithFileAndArch() API (rdar://problem/39960149). In the meantime, since this script does not really need to specify the architecture, we can work around the problem by using CreateTarget(). That's simpler anyway. rdar://problem/38181372 --- test/Runtime/linux-fatal-backtrace.swift | 1 - utils/symbolicate-linux-fatal | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/test/Runtime/linux-fatal-backtrace.swift b/test/Runtime/linux-fatal-backtrace.swift index 202983c7a5a06..6df5ec36bacb6 100644 --- a/test/Runtime/linux-fatal-backtrace.swift +++ b/test/Runtime/linux-fatal-backtrace.swift @@ -4,7 +4,6 @@ // REQUIRES: executable_test // REQUIRES: OS=linux-gnu // REQUIRES: lldb -// REQUIRES: rdar38181372 // Backtraces are not emitted when optimizations are enabled. This test can not // run when optimizations are enabled. diff --git a/utils/symbolicate-linux-fatal b/utils/symbolicate-linux-fatal index 2fcb8dbd3f873..9fffd416aa0ca 100755 --- a/utils/symbolicate-linux-fatal +++ b/utils/symbolicate-linux-fatal @@ -55,8 +55,7 @@ def process_ldd(lddoutput): def create_lldb_target(binary, memmap): lldb_debugger = lldb.SBDebugger.Create() - lldb_target = lldb_debugger.CreateTargetWithFileAndArch( - binary, lldb.LLDB_ARCH_DEFAULT) + lldb_target = lldb_debugger.CreateTarget(binary) module = lldb_target.GetModuleAtIndex(0) for dynlib_path in memmap: module = lldb_target.AddModule(