[stdlib] Rename "PrivateDarwin" to "PrivateLibc" #1395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftPrivateDarwinExtras is used by non-Darwin platforms as well; its name is misleading. Rename it to SwiftPrivateLibcExtras, which is closer to its actual function.
Contributor
|
@swift-ci Please test |
Contributor
Author
|
Hmm, looks like the OS X tests are still broken due to the SwiftPM... glad to see it worked on Linux, though! |
Contributor
|
@modocache Yep. All CI runs today fail reliably on this one. |
Contributor
|
All other tests passed, though. Should be good to merge! |
gribozavr
added a commit
that referenced
this pull request
Feb 22, 2016
[stdlib] Rename "PrivateDarwin" to "PrivateLibc"
Contributor
Author
|
Excellent, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftPrivateDarwinExtras is used by non-Darwin platforms as well; its name is misleading. Rename it to SwiftPrivateLibcExtras, which is closer to its actual function.