Merge pull request #60948 from AnthonyLatsis/migrate-test-suite-to-gh-issues-21

AnthonyLatsis · web-flow · commit ea9c66d73636 · 2022-09-17T12:42:57.000+03:00
Gardening: Migrate test suite to GH issues p. 21
diff --git a/test/SILGen/magic_identifier_file.swift b/test/SILGen/magic_identifier_file.swift
@@ -21,7 +21,9 @@
 // Test in "Swift 6" mode:
 // RUN: %target-swift-emit-silgen -I %t -enable-experimental-concise-pound-file -module-name Foo %/s | %FileCheck --check-prefixes=BOTH,CONCISE %s
 
-// TODO: Update RUN lines currently using -enable-experimental-concise-pound-file to use -swift-version <whatever> instead. (SR-13199)
+// TODO: Update RUN lines currently using
+// -enable-experimental-concise-pound-file to use -swift-version <whatever>
+// instead (https://github.com/apple/swift/issues/55639).
 
 import MagicIdentifierFileSwift5
 import MagicIdentifierFileSwift6
diff --git a/test/SILGen/mangling_retroactive.swift b/test/SILGen/mangling_retroactive.swift
@@ -93,7 +93,7 @@ extension ExternalGeneric: Error where Argument: Error { }
 func useRequiresError(_: RequiresError<ExternalGeneric<Error>>) {}
 // CHECK: sil hidden [ossa] @$s20mangling_retroactive16useRequiresErroryyAA0dE0Vy12RetroactiveB15ExternalGenericVys0E0_pGAIsAhAsAH_psAHHPyHC_HCg_GF
 
-// SR-10926
+// https://github.com/apple/swift/issues/53317
 protocol OurBaseProtocol: P {
   associatedtype Assoc: P
 }
diff --git a/test/SILGen/objc_attr_NSManaged.swift b/test/SILGen/objc_attr_NSManaged.swift
@@ -80,7 +80,9 @@ func testFinal(_ obj: FinalGizmo) -> String {
   return obj.y
 }
 
-// SR-2673: @NSManaged property can't satisfy protocol requirement
+// https://github.com/apple/swift/issues/45278
+// '@NSManaged' property can't satisfy protocol requirement
+
 @objc protocol ObjCProto {
   var managedProp: String { get set }
   var managedExtProp: AnyObject { get }
@@ -94,7 +96,9 @@ extension ProtoAdopter {
 }
 
 
-// SR-6534: @NSManaged properties can be 'final'
+// https://github.com/apple/swift/issues/49084
+// '@NSManaged' properties can be 'final'
+
 protocol EntityIDProto {
   var entityID: String { get set }
 }
diff --git a/test/SILGen/objc_error.swift b/test/SILGen/objc_error.swift
@@ -135,7 +135,7 @@ func eraseFictionalServerError() -> Error {
 }
 // CHECK: } // end sil function '$s10objc_error25eraseFictionalServerErrors0F0_pyF'
 
-// SR-1562
+// https://github.com/apple/swift/issues/44171
 extension Error {
   // CHECK-LABEL: sil hidden [ossa] @$ss5ErrorP10objc_errorE16convertToNSErrorSo0F0CyF
   // CHECK: bb0([[SELF:%[0-9]+]] : $*Self)
diff --git a/test/SILGen/objc_extensions.swift b/test/SILGen/objc_extensions.swift
@@ -171,7 +171,8 @@ extension SubSub {
   }
 }
 
-// SR-1025
+// https://github.com/apple/swift/issues/43637
+
 extension Base {
   fileprivate static var x = 1
 }
diff --git a/test/SILGen/objc_init_iuo_override.swift b/test/SILGen/objc_init_iuo_override.swift
@@ -1,8 +1,8 @@
-// SR-8789
-
 // RUN: %target-swift-emit-silgen -verify -import-objc-header %S/Inputs/objc_init_iuo_override.h %s
 // REQUIRES: objc_interop
 
+// https://github.com/apple/swift/issues/51297
+
 class ChildClass: ParentClass {}
 
 class GrandchildClass: ChildClass {
diff --git a/test/SILGen/objc_properties.swift b/test/SILGen/objc_properties.swift
@@ -226,9 +226,9 @@ class NonObjCBaseClass : NSObject {
 // CHECK-LABEL: sil private [thunk] [ossa] @$s15objc_properties12ObjCSubclassC8propertySivsTo
 
 // Make sure lazy properties that witness @objc protocol requirements are
-// correctly formed
+// correctly formed.
 //
-// <https://bugs.swift.org/browse/SR-1825>
+// https://github.com/apple/swift/issues/44434
 
 @objc protocol HasProperty {
     @objc var window: NSObject? { get set }
diff --git a/test/SILGen/property_wrappers.swift b/test/SILGen/property_wrappers.swift
@@ -728,7 +728,9 @@ public class Container {
   }
 }
 
-// SR-11303 / rdar://problem/54311335 - crash due to wrong archetype used in generated SIL
+// rdar://problem/54311335
+// https://github.com/apple/swift/issues/53704
+// Crash due to wrong archetype used in generated SIL
 public protocol TestProtocol {}
 public class TestClass<T> {
   @WrapperWithInitialValue var value: T
@@ -801,7 +803,9 @@ extension UsesMyPublished {
   }
 }
 
-// SR-11603 - crash due to incorrect lvalue computation
+// https://github.com/apple/swift/issues/54010
+// Crash due to incorrect lvalue computation
+
 @propertyWrapper
 struct StructWrapper<T> {
   var wrappedValue: T
@@ -815,7 +819,7 @@ class ClassWrapper<T> {
   }
 }
 
-struct SR_11603 {
+struct S_54010 {
   @StructWrapper @ClassWrapper var prop: Int
 
   func foo() {
@@ -908,7 +912,9 @@ struct NonMutatingWrapperTestStruct {
 }
 
 
-// SR-12443: Crash on property with wrapper override that adds observer.
+// https://github.com/apple/swift/issues/54882
+// Crash on property with wrapper override that adds observer.
+
 @propertyWrapper
 struct BasicIntWrapper {
   var wrappedValue: Int
@@ -957,31 +963,33 @@ struct TestAutoclosureComposition {
   @Once @ObservedObject var model = Model()
 }
 
+// https://github.com/apple/swift/issues/58201
+
 @propertyWrapper
-struct SR_15940Foo {
+struct BasicComputedIntWrapper {
   var wrappedValue: Int { 0 }
 }
 
-struct SR_15940_C {
+struct S_58201 {
   func a() {
-    @SR_15940Foo var b: Int
+    @BasicComputedIntWrapper var b: Int
   }
 }
 
-// CHECK-LABEL: sil hidden [ossa] @$s17property_wrappers10SR_15940_CV1ayyF : $@convention(method) (SR_15940_C) -> () {
-// CHECK: bb0(%0 : $SR_15940_C):
-// CHECK-NEXT:  debug_value %0 : $SR_15940_C, let, name "self", argno 1, implicit
-// CHECK-NEXT:  [[BOX:%.*]] = alloc_box ${ var SR_15940Foo }, var, name "_b"
-// CHECK-NEXT:  [[BOXADDR:%.*]] = project_box [[BOX]] : ${ var SR_15940Foo }, 0
-// CHECK-NEXT:  [[METATYPE:%.*]] = metatype $@thin SR_15940Foo.Type
-// CHECK-NEXT:  // function_ref SR_15940Foo.init()
-// CHECK-NEXT:  [[DEFAULTVALUE_FN:%.*]] = function_ref @$s17property_wrappers11SR_15940FooVACycfC : $@convention(method) (@thin SR_15940Foo.Type) -> SR_15940Foo
-// CHECK-NEXT:  [[DEFAULTRESULT:%.*]] = apply [[DEFAULTVALUE_FN]]([[METATYPE]]) : $@convention(method) (@thin SR_15940Foo.Type) -> SR_15940Foo
-// CHECK-NEXT:  store [[DEFAULTRESULT]] to [trivial] [[BOXADDR]] : $*SR_15940Foo
-// CHECK-NEXT:  destroy_value [[BOX]] : ${ var SR_15940Foo }
+// CHECK-LABEL: sil hidden [ossa] @$s17property_wrappers7S_58201V1ayyF : $@convention(method) (S_58201) -> () {
+// CHECK: bb0(%0 : $S_58201):
+// CHECK-NEXT:  debug_value %0 : $S_58201, let, name "self", argno 1, implicit
+// CHECK-NEXT:  [[BOX:%.*]] = alloc_box ${ var BasicComputedIntWrapper }, var, name "_b"
+// CHECK-NEXT:  [[BOXADDR:%.*]] = project_box [[BOX]] : ${ var BasicComputedIntWrapper }, 0
+// CHECK-NEXT:  [[METATYPE:%.*]] = metatype $@thin BasicComputedIntWrapper.Type
+// CHECK-NEXT:  // function_ref BasicComputedIntWrapper.init()
+// CHECK-NEXT:  [[DEFAULTVALUE_FN:%.*]] = function_ref @$s17property_wrappers23BasicComputedIntWrapperVACycfC : $@convention(method) (@thin BasicComputedIntWrapper.Type) -> BasicComputedIntWrapper
+// CHECK-NEXT:  [[DEFAULTRESULT:%.*]] = apply [[DEFAULTVALUE_FN]]([[METATYPE]]) : $@convention(method) (@thin BasicComputedIntWrapper.Type) -> BasicComputedIntWrapper
+// CHECK-NEXT:  store [[DEFAULTRESULT]] to [trivial] [[BOXADDR]] : $*BasicComputedIntWrapper
+// CHECK-NEXT:  destroy_value [[BOX]] : ${ var BasicComputedIntWrapper }
 // CHECK-NEXT:  [[TUPLE:%.*]] = tuple ()
 // CHECK-NEXT:  return [[TUPLE]] : $()
-// CHECK-NEXT:  } // end sil function '$s17property_wrappers10SR_15940_CV1ayyF
+// CHECK-NEXT:  } // end sil function '$s17property_wrappers7S_58201V1ayyF'
 
 // CHECK-LABEL: sil_vtable ClassUsingWrapper {
 // CHECK-NEXT:  #ClassUsingWrapper.x!getter: (ClassUsingWrapper) -> () -> Int : @$s17property_wrappers17ClassUsingWrapperC1xSivg   // ClassUsingWrapper.x.getter
diff --git a/test/SILGen/protocols.swift b/test/SILGen/protocols.swift
@@ -429,7 +429,7 @@ public func test(_ p: Proto) {
 // CHECK: end_apply [[TOKEN]]
 // CHECK: return
 
-// SR-11748
+// https://github.com/apple/swift/issues/54155
 
 protocol SelfReturningSubscript {
   subscript(b: Int) -> Self { get }
diff --git a/test/SILGen/reabstract-tuple.swift b/test/SILGen/reabstract-tuple.swift
@@ -1,7 +1,7 @@
 
 // RUN: %target-swift-emit-silgen -verify %s | %FileCheck %s
 
-// SR-3090:
+// https://github.com/apple/swift/issues/45680
 
 class Box<T> {
     public let value: T
diff --git a/test/SILGen/subscripts.swift b/test/SILGen/subscripts.swift
@@ -103,7 +103,8 @@ do {
   inoutFunc(&b[(1,2),(2,3)])
 }
 
-// https://bugs.swift.org/browse/SR-1816
+// https://github.com/apple/swift/issues/44425
+
 public struct Flags: OptionSet {
   public var rawValue: Int
   public init(rawValue: Int) { self.rawValue = rawValue }
diff --git a/test/SILGen/super.swift b/test/SILGen/super.swift
@@ -171,8 +171,10 @@ public class ChildToFixedParent : OutsideParent {
   // CHECK: } // end sil function '$s5super18ChildToFixedParentC11returnsSelfACXDyFZ'
 }
 
-// https://bugs.swift.org/browse/SR-10260 - super.foo() call across a module
-// boundary from a subclass that does not override foo().
+// https://github.com/apple/swift/issues/52660
+// 'super.foo()' call across a module boundary from a subclass that does
+// not override 'foo()'.
+
 public class SuperCallToNonOverriddenMethod : OutsideParent {
   public func newMethod() {
     super.method()
diff --git a/test/SILGen/switch.swift b/test/SILGen/switch.swift
@@ -1050,7 +1050,8 @@ func testOptionalEnumMixWithNil(_ a : Int?) -> Int {
   }
 }
 
-// SR-3518
+// https://github.com/apple/swift/issues/46106
+//
 // CHECK-LABEL: sil hidden [ossa] @$s6switch43testMultiPatternsWithOuterScopeSameNamedVar4base6filterySiSg_AEtF
 func testMultiPatternsWithOuterScopeSameNamedVar(base: Int?, filter: Int?) {
   switch(base, filter) {
@@ -1288,10 +1289,11 @@ func partial_address_only_tuple_dispatch_with_fail_case(_ name: Klass, _ value:
 }
 
 // This was crashing the ownership verifier at some point and was reported in
-// SR-6664. Just make sure that we still pass the ownership verifier.
-
+// https://github.com/apple/swift/issues/49213. Just make sure that we still
+// pass the ownership verifier.
+//
 // `indirect` is necessary; generic parameter is necessary.
-indirect enum SR6664_Base<Element> {
+indirect enum IndirectGenericEnum<Element> {
   // Tuple associated value is necessary; one element must be a function,
   // the other must be a non-function using the generic parameter.
   // (The original associated value was `(where: (Element) -> Bool, of: Element?)`,
diff --git a/test/SILGen/type_lowering_subst_function_type_caseiterable.swift b/test/SILGen/type_lowering_subst_function_type_caseiterable.swift
@@ -1,7 +1,7 @@
 // RUN: %target-swift-emit-silgen %s | %FileCheck %s
 
-// This is a GenericSignatureBuilder bug fixed with the Requirement Machine, from
-// https://bugs.swift.org/browse/SR-15917.
+// This is a GenericSignatureBuilder bug fixed with the Requirement Machine,
+// from https://github.com/apple/swift/issues/58178.
 
 public struct Foo<Unused: CaseIterable> {
   public struct Nested {}
diff --git a/test/SILGen/unreachable_code.swift b/test/SILGen/unreachable_code.swift
@@ -109,9 +109,10 @@ func testUnreachableCase5(a : Tree) {
   }
 }
 
+// https://github.com/apple/swift/issues/48333
 func testOptionalEvaluationBreak(a : Tree) {
-  class SR5763 { func foo() {} }
-  func createOptional() -> SR5763? { return SR5763() }
+  class C { func foo() {} }
+  func createOptional() -> C? { return C() }
   switch a {
   case _:
     break
@@ -130,7 +131,8 @@ class TestThrowInInit {
   }
 }
 
-func sr6141() {
+// https://github.com/apple/swift/issues/48696
+func f_48696() {
   var bar: String? = ""
   return;
   bar?.append("x")  // expected-warning{{code after 'return' will never be executed}}
@@ -147,11 +149,12 @@ func testUnreachableCatchClause() {
   }
 }
 
-func sr13639() -> Int {
+// https://github.com/apple/swift/issues/56075
+func f_56075() -> Int {
   return Foo.bar
   struct Foo { // no-warning
     static var bar = 0
-    // CHECK: sil private @$s16unreachable_code7sr13639SiyF3FooL_V7fooFuncyyF : $@convention(method) (Foo) -> ()
+    // CHECK: sil private @$s16unreachable_code7f_56075SiyF3FooL_V7fooFuncyyF : $@convention(method) (Foo) -> ()
     func fooFunc() {}
   }
   func appendix() {} // no-warning
diff --git a/test/SILOptimizer/OSLogFullOptTest.swift b/test/SILOptimizer/OSLogFullOptTest.swift
@@ -15,7 +15,7 @@
 // dead_array_elim.swift. The problem can be overcome by handling
 // non-trivial stores in OSSA, as described here:
 //   [OSSA] Improve DeadObjectElimination to handle array copies
-//   https://bugs.swift.org/browse/SR-13782
+//   https://github.com/apple/swift/issues/56179
 // Once that bug is fixed, remove the requirement: swift_stdlib_no_asserts.
 
 import OSLogTestHelper
diff --git a/test/SILOptimizer/copyforward_ossa.sil b/test/SILOptimizer/copyforward_ossa.sil
@@ -482,7 +482,10 @@ bb0(%0 : $*T, %1 : $*T):
   return %r1 : $()
 }
 
-// <rdar://problem/43888666> [SR-8526]: Memory leak after switch in release configuration
+// rdar://problem/43888666
+// https://github.com/apple/swift/issues/51046
+// Memory leak after switch in release configuration
+//
 // CHECK-LABEL: sil [ossa] @testGlobalHoistToStoredValue : $@convention(thin) (@owned AClass, @inout AClass) -> () {
 // CHECK: bb0(%0 : @owned $AClass, %1 : $*AClass):
 // CHECK-NEXT:   [[LOCAL:%.*]] = alloc_stack $AClass
diff --git a/test/SILOptimizer/dead_array_elim.swift b/test/SILOptimizer/dead_array_elim.swift
@@ -22,7 +22,7 @@
 // second array is initialized by copying the first. This problem can be
 // overcome by handling non-trivial stores in OSSA, as described here:
 //   [OSSA] Improve DeadObjectElimination to handle array copies
-//   https://bugs.swift.org/browse/SR-13782
+//   https://github.com/apple/swift/issues/56179
 // Once that bug is fixed, remove the requirement: swift_stdlib_no_asserts.
 
 // CHECK-LABEL: sil hidden @$s15dead_array_elim24testDeadArrayEliminationyyF
diff --git a/test/SILOptimizer/dead_code_elimination_ossa.sil b/test/SILOptimizer/dead_code_elimination_ossa.sil
@@ -296,7 +296,8 @@ bb0(%0 : @owned $(String, (Int, Int, String))):
 
 // Test fix_lifetime of a struct and tuple. It cannot be removed
 // without proving reference uniqueness first.
-// rdar://36038096 ([SR-6608] DeadCodeElimination removes fix_lifetime instructions.)
+// rdar://36038096
+// https://github.com/apple/swift/issues/49158
 //
 // CHECK-LABEL: @testFixLifetimeTuple : $@convention(thin) (@owned S, @owned AnyObject) -> () {
 // CHECK: bb0(%0 : $S, %1 : $AnyObject):
diff --git a/test/SILOptimizer/definite_init_diagnostics.swift b/test/SILOptimizer/definite_init_diagnostics.swift
diff --git a/test/SILOptimizer/di_property_wrappers.swift b/test/SILOptimizer/di_property_wrappers.swift
diff --git a/test/SILOptimizer/di_property_wrappers_errors.swift b/test/SILOptimizer/di_property_wrappers_errors.swift
diff --git a/test/SILOptimizer/diagnose_unreachable.swift b/test/SILOptimizer/diagnose_unreachable.swift
diff --git a/test/SILOptimizer/diagnostic_constant_propagation.swift b/test/SILOptimizer/diagnostic_constant_propagation.swift

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ extension ExternalGeneric: Error where Argument: Error { }`
`93`	`93`	`func useRequiresError(_: RequiresError<ExternalGeneric<Error>>) {}`
`94`	`94`	`// CHECK: sil hidden [ossa] @$s20mangling_retroactive16useRequiresErroryyAA0dE0Vy12RetroactiveB15ExternalGenericVys0E0_pGAIsAhAsAH_psAHHPyHC_HCg_GF`
`95`	`95`
`96`		`-// SR-10926`
	`96`	`+// https://github.com/apple/swift/issues/53317`
`97`	`97`	`protocol OurBaseProtocol: P {`
`98`	`98`	`associatedtype Assoc: P`
`99`	`99`	`}`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,9 @@ func testFinal(_ obj: FinalGizmo) -> String {`
`80`	`80`	`return obj.y`
`81`	`81`	`}`
`82`	`82`
`83`		`-// SR-2673: @NSManaged property can't satisfy protocol requirement`
	`83`	`+// https://github.com/apple/swift/issues/45278`
	`84`	`+// '@NSManaged' property can't satisfy protocol requirement`
	`85`	`+`
`84`	`86`	`@objc protocol ObjCProto {`
`85`	`87`	`var managedProp: String { get set }`
`86`	`88`	`var managedExtProp: AnyObject { get }`
`@@ -94,7 +96,9 @@ extension ProtoAdopter {`
`94`	`96`	`}`
`95`	`97`
`96`	`98`
`97`		`-// SR-6534: @NSManaged properties can be 'final'`
	`99`	`+// https://github.com/apple/swift/issues/49084`
	`100`	`+// '@NSManaged' properties can be 'final'`
	`101`	`+`
`98`	`102`	`protocol EntityIDProto {`
`99`	`103`	`var entityID: String { get set }`
`100`	`104`	`}`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ func eraseFictionalServerError() -> Error {`
`135`	`135`	`}`
`136`	`136`	`// CHECK: } // end sil function '$s10objc_error25eraseFictionalServerErrors0F0_pyF'`
`137`	`137`
`138`		`-// SR-1562`
	`138`	`+// https://github.com/apple/swift/issues/44171`
`139`	`139`	`extension Error {`
`140`	`140`	`// CHECK-LABEL: sil hidden [ossa] @$ss5ErrorP10objc_errorE16convertToNSErrorSo0F0CyF`
`141`	`141`	`// CHECK: bb0([[SELF:%[0-9]+]] : $*Self)`
Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,8 @@ extension SubSub {`
`171`	`171`	`}`
`172`	`172`	`}`
`173`	`173`
`174`		`-// SR-1025`
	`174`	`+// https://github.com/apple/swift/issues/43637`
	`175`	`+`
`175`	`176`	`extension Base {`
`176`	`177`	`fileprivate static var x = 1`
`177`	`178`	`}`