Merge pull request #3844 from CodaFi/cleanup

Cleanup validation tests after SE-0089

Author: shahmishal

validation-test/StdlibUnittest/RaceTest.swift

@@ -55,11 +55,11 @@ struct RaceTest1 : RaceTestWithPerTrialData {
       case Observation(0x1):
         sink(.pass)
       case Observation(0x2):
-        sink(.passInteresting(String(observation)))
+        sink(.passInteresting(String(describing: observation)))
       case Observation(0xffff):
         sink(.failure)
       case Observation(0xfffe):
-        sink(.failureInteresting(String(observation)))
+        sink(.failureInteresting(String(describing: observation)))
       default:
         fatalError("should not happen")
       }

validation-test/stdlib/AtomicInt.swift

@@ -144,10 +144,10 @@ struct AtomicInt_fetchAndAdd_1_RaceTest : RaceTestWithPerTrialData {
            Observation(2, 10, 20,  0, 40),
            Observation(2, 10, 20, 30,  0),
            Observation(2, 10, 20, 30, 40):
-        sink(.passInteresting(String(observation)))
+        sink(.passInteresting(String(describing: observation)))
 
       default:
-        sink(.failureInteresting(String(observation)))
+        sink(.failureInteresting(String(describing: observation)))
       }
     }
   }
@@ -215,10 +215,10 @@ struct AtomicInt_fetchAndAdd_ReleaseAtomicStores_1_RaceTest
            Observation(2, 10, 20,  0,  0),
            Observation(2, 10, 20, 30,  0),
            Observation(2, 10, 20, 30, 40):
-        sink(.passInteresting(String(observation)))
+        sink(.passInteresting(String(describing: observation)))
 
       default:
-        sink(.failureInteresting(String(observation)))
+        sink(.failureInteresting(String(describing: observation)))
       }
     }
   }
@@ -302,10 +302,10 @@ struct AtomicInt_fetchAndAdd_ReleaseAtomicStores_2_RaceTest
            Observation(2, 10, 20,  0,  0),
            Observation(2, 10, 20, 30,  0),
            Observation(2, 10, 20, 30, 40):
-        sink(.passInteresting(String(observation)))
+        sink(.passInteresting(String(describing: observation)))
 
       default:
-        sink(.failureInteresting(String(observation)))
+        sink(.failureInteresting(String(describing: observation)))
       }
     }
   }
@@ -429,10 +429,10 @@ struct AtomicInt_fetchAndAdd_ReleaseNonAtomicStores_RaceTest
            Observation(2, 10, 20,  0,  0, 100, 200, 999, 999),
            Observation(2, 10, 20, 30,  0, 100, 200, 300, 999),
            Observation(2, 10, 20, 30, 40, 100, 200, 300, 400):
-        sink(.passInteresting(String(observation)))
+        sink(.passInteresting(String(describing: observation)))
 
       default:
-        sink(.failureInteresting(String(observation)))
+        sink(.failureInteresting(String(describing: observation)))
       }
     }
   }
@@ -510,10 +510,10 @@ struct AtomicInt_fetchAndAnd_1_RaceTest : RaceTestWithPerTrialData {
            Observation(2,  8, 16, -4, 64),
            Observation(2,  8, 16, 32, -4),
            Observation(2,  8, 16, 32, 64):
-        sink(.passInteresting(String(observation)))
+        sink(.passInteresting(String(describing: observation)))
 
       default:
-        sink(.failureInteresting(String(observation)))
+        sink(.failureInteresting(String(describing: observation)))
       }
     }
   }
@@ -591,10 +591,10 @@ struct AtomicInt_fetchAndOr_1_RaceTest : RaceTestWithPerTrialData {
            Observation(2, 11, 19,  3, 67),
            Observation(2, 11, 19, 35,  3),
            Observation(2, 11, 19, 35, 67):
-        sink(.passInteresting(String(observation)))
+        sink(.passInteresting(String(describing: observation)))
 
       default:
-        sink(.failureInteresting(String(observation)))
+        sink(.failureInteresting(String(describing: observation)))
       }
     }
   }
@@ -672,10 +672,10 @@ struct AtomicInt_fetchAndXor_1_RaceTest : RaceTestWithPerTrialData {
            Observation(2, 10, 18,  3, 66),
            Observation(2, 10, 18, 34,  3),
            Observation(2, 10, 18, 34, 66):
-        sink(.passInteresting(String(observation)))
+        sink(.passInteresting(String(describing: observation)))
 
       default:
-        sink(.failureInteresting(String(observation)))
+        sink(.failureInteresting(String(describing: observation)))
       }
     }
   }
@@ -773,7 +773,7 @@ struct AtomicInitializeARCRefRaceTest : RaceTestWithPerTrialData {
         // Lost race, value destroyed.
         lostRace += 1
       default:
-        sink(.failureInteresting(String(observation)))
+        sink(.failureInteresting(String(describing: observation)))
       }
     }
     if wonRace != 1 {

validation-test/stdlib/String.swift

@@ -1090,7 +1090,7 @@ StringTests.test("unicodeViews") {
   // slices
   // It is 4 bytes long, so it should return a replacement character.
   expectEqual(
-    "\u{FFFD}", String(
+    "\u{FFFD}", String(describing: 
       winter.utf8[
         winter.utf8.startIndex
         ..<