Merge pull request #68484 from kubamracek/embedded-perfect-bug

kubamracek · web-flow · commit df4f824b0294 · 2023-09-13T11:16:30.000-07:00
[embedded] Fix accidentally reversed logic in isGenericFunction + addAllNonGenericFunctions
diff --git a/SwiftCompilerSources/Sources/Optimizer/ModulePasses/MandatoryPerformanceOptimizations.swift b/SwiftCompilerSources/Sources/Optimizer/ModulePasses/MandatoryPerformanceOptimizations.swift
@@ -312,7 +312,7 @@ fileprivate struct FunctionWorklist {
   }
 
   mutating func addAllNonGenericFunctions(of moduleContext: ModulePassContext) {
-    for f in moduleContext.functions where f.isGenericFunction {
+    for f in moduleContext.functions where !f.isGenericFunction {
       pushIfNotVisited(f)
     }
     return
diff --git a/include/swift/SIL/SILBridging.h b/include/swift/SIL/SILBridging.h
@@ -261,7 +261,7 @@ struct BridgedFunction {
   }
 
   bool isGenericFunction() const {
-    return getFunction()->getGenericSignature().isNull();
+    return !getFunction()->getGenericSignature().isNull();
   }
 
   bool hasSemanticsAttr(llvm::StringRef attrName) const {

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,7 @@ fileprivate struct FunctionWorklist {`
`312`	`312`	`}`
`313`	`313`
`314`	`314`	`mutating func addAllNonGenericFunctions(of moduleContext: ModulePassContext) {`
`315`		`- for f in moduleContext.functions where f.isGenericFunction {`
	`315`	`+ for f in moduleContext.functions where !f.isGenericFunction {`
`316`	`316`	`pushIfNotVisited(f)`
`317`	`317`	`}`
`318`	`318`	`return`
Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,7 @@ struct BridgedFunction {`
`261`	`261`	`}`
`262`	`262`
`263`	`263`	`bool isGenericFunction() const {`
`264`		`- return getFunction()->getGenericSignature().isNull();`
	`264`	`+ return !getFunction()->getGenericSignature().isNull();`
`265`	`265`	`}`
`266`	`266`
`267`	`267`	`bool hasSemanticsAttr(llvm::StringRef attrName) const {`