Merge pull request #23308 from rintaro/ide-completion-rdar48896424

[CodeCompletion] Fix an assertion failure

Author: rintaro

lib/IDE/CodeCompletion.cpp

@@ -1948,6 +1948,10 @@ class CompletionLookup final : public swift::VisibleDeclConsumer {
         if (!MaybeNominalType->mayHaveMembers())
           return T;
 
+        // We can't do anything if the base type has unbound generic parameters.
+        if (MaybeNominalType->hasUnboundGenericType())
+          return T;
+
         // For everything else, substitute in the base type.
         auto Subs = MaybeNominalType->getMemberSubstitutionMap(M, VD);
 

validation-test/IDE/crashers_2_fixed/rdar48896424.swift

@@ -0,0 +1,17 @@
+// RUN: %target-swift-ide-test -code-completion -code-completion-token=COMPLETE -source-filename=%s
+
+class Foo<T> {
+}
+
+extension Foo where T: Comparable {
+  func foo() {}
+}
+
+protocol P {
+  typealias alias = Foo
+}
+protocol P {}
+
+func Test() {
+  P.alias.#^COMPLETE^#
+}