Merge pull request #70815 from zoecarver/perf-annotation-ns-direct-exception

Author: zoecarver

lib/SIL/Utils/InstructionUtils.cpp

@@ -24,6 +24,8 @@
 #include "swift/SIL/SILBuilder.h"
 #include "swift/SIL/SILVisitor.h"
 
+#include "clang/AST/DeclObjC.h"
+
 using namespace swift;
 
 SILValue swift::lookThroughOwnershipInsts(SILValue v) {
@@ -915,7 +917,17 @@ RuntimeEffect swift::getRuntimeEffect(SILInstruction *inst, SILType &impactType)
     auto as = ApplySite(inst);
 
     switch (as.getSubstCalleeType()->getRepresentation()) {
-    case SILFunctionTypeRepresentation::ObjCMethod:
+    case SILFunctionTypeRepresentation::ObjCMethod: {
+      if (auto *callee = as.getCalleeFunction()) {
+        if (auto *clangDecl = callee->getClangDecl()) {
+          if (auto clangMethodDecl = dyn_cast<clang::ObjCMethodDecl>(clangDecl)) {
+            if (clangMethodDecl->isDirectMethod()) {
+              break;
+            }
+          }
+        }
+      }
+    }
     case SILFunctionTypeRepresentation::Block:
       rt |= RuntimeEffect::ObjectiveC | RuntimeEffect::MetaData;
       break;

test/SILOptimizer/performance-diags-ns-direct.swift

@@ -0,0 +1,32 @@
+// RUN: %empty-directory(%t)
+// RUN: split-file %s %t
+
+// RUN: %target-swift-frontend -emit-ir -verify -I %t/Inputs %t/test.swift 
+
+// REQUIRES: objc_interop
+
+//--- Inputs/header.h
+
+@interface Interface
+
+- (void)test __attribute__((objc_direct)) __attribute__((swift_attr("@_noObjCBridging")));
+
+@end
+
+
+//--- Inputs/module.modulemap
+
+module ObjCModule {
+    header "header.h"
+    export *
+}
+
+//--- test.swift
+
+import Foundation
+import ObjCModule
+
+@_noObjCBridging
+func test(i: Interface) {
+  i.test()
+}