Merge pull request #6808 from hughbe/msvc-unreachable

FIx recently introduced MSVC control path warnings

Author: slavapestov

include/swift/AST/Decl.h

@@ -2646,6 +2646,8 @@ static inline bool isRawPointerKind(PointerTypeKind PTK) {
   case PTK_AutoreleasingUnsafeMutablePointer:
     return false;
   }
+
+  llvm_unreachable("Unhandled PointerTypeKind in switch.");
 }
 
 /// NominalTypeDecl - a declaration of a nominal type, like a struct.

lib/AST/LayoutConstraint.cpp

@@ -58,6 +58,8 @@ StringRef LayoutConstraintInfo::getName(LayoutConstraintKind Kind) {
   case LayoutConstraintKind::TrivialOfExactSize:
     return "_Trivial";
   }
+
+  llvm_unreachable("Unhandled LayoutConstraintKind in switch.");
 }
 
 SourceRange LayoutConstraintLoc::getSourceRange() const { return getLoc(); }

lib/Basic/Demangler.cpp

@@ -1657,6 +1657,8 @@ NodePointer Demangler::demangleGenericRequirement() {
     return LayoutRequirement;
   }
   }
+
+  llvm_unreachable("Unhandled TypeKind in switch.");
 }
 
 NodePointer Demangler::demangleGenericType() {

lib/SIL/SILOwnershipVerifier.cpp

@@ -442,6 +442,8 @@ OwnershipUseCheckerResult OwnershipCompatibilityUseChecker::visitCallee(
   case ParameterConvention::Direct_Guaranteed:
     return {compatibleWithOwnership(ValueOwnershipKind::Guaranteed), false};
   }
+
+  llvm_unreachable("Unhandled ParameterConvention in switch.");
 }
 
 OwnershipUseCheckerResult
@@ -468,6 +470,8 @@ OwnershipCompatibilityUseChecker::visitApplyInst(ApplyInst *I) {
   case SILArgumentConvention::Direct_Deallocating:
     llvm_unreachable("No ownership associated with deallocating");
   }
+
+  llvm_unreachable("Unhandled SILArgumentConvention in switch.");
 }
 
 OwnershipUseCheckerResult
@@ -494,6 +498,8 @@ OwnershipCompatibilityUseChecker::visitTryApplyInst(TryApplyInst *I) {
   case SILArgumentConvention::Direct_Deallocating:
     llvm_unreachable("No ownership associated with deallocating");
   }
+
+  llvm_unreachable("Unhandled SILArgumentConvention in switch.");
 }
 
 OwnershipUseCheckerResult

lib/SIL/SILType.cpp

@@ -601,4 +601,6 @@ ValueOwnershipKind SILResultInfo::getOwnershipKind(SILModule &M) const {
       return ValueOwnershipKind::Trivial;
     return ValueOwnershipKind::Unowned;
   }
+
+  llvm_unreachable("Unhandled ResultConvention in switch.");
 }

lib/SIL/SILValue.cpp

@@ -114,6 +114,8 @@ llvm::raw_ostream &swift::operator<<(llvm::raw_ostream &os,
   case ValueOwnershipKind::Any:
     return os << "Any";
   }
+
+  llvm_unreachable("Unhandled ValueOwnershipKind in switch.");
 }
 
 Optional<ValueOwnershipKind>
@@ -433,6 +435,8 @@ ValueOwnershipKindVisitor::visitSILFunctionArgument(SILFunctionArgument *Arg) {
   case SILArgumentConvention::Direct_Deallocating:
     llvm_unreachable("No ownership associated with deallocating");
   }
+
+  llvm_unreachable("Unhandled SILArgumentConvention in switch.");
 }
 
 // This is a forwarding instruction through only one of its arguments.
@@ -486,6 +490,8 @@ ValueOwnershipKindVisitor::visitLoadInst(LoadInst *LI) {
   case LoadOwnershipQualifier::Trivial:
     return ValueOwnershipKind::Trivial;
   }
+
+  llvm_unreachable("Unhandled LoadOwnershipQualifier in switch.");
 }
 
 ValueOwnershipKind SILValue::getOwnershipKind() const {

lib/Sema/CSApply.cpp

@@ -6409,6 +6409,8 @@ Expr *ExprRewriter::finishApply(ApplyExpr *apply, Type openedType,
       case DeclTypeCheckingSemantics::Normal:
         return nullptr;
       }
+
+      llvm_unreachable("Unhandled DeclTypeCheckingSemantics in switch.");
     };
 
   // The function is always an rvalue.

lib/Sema/ConstraintSystem.cpp

@@ -1359,6 +1359,8 @@ resolveOverloadForDeclWithSpecialTypeCheckingSemantics(ConstraintSystem &CS,
     return true;
   }
   }
+
+  llvm_unreachable("Unhandled DeclTypeCheckingSemantics in switch.");
 }
 
 void ConstraintSystem::resolveOverload(ConstraintLocator *locator,

lib/Sema/TypeCheckStmt.cpp

@@ -1038,6 +1038,8 @@ static void diagnoseIgnoredLiteral(TypeChecker &TC, LiteralExpr *LE) {
 #include "swift/AST/ExprNodes.def"
       llvm_unreachable("Not a literal expression");
     }
+
+    llvm_unreachable("Unhandled ExprKind in switch.");
   };
 
   TC.diagnose(LE->getLoc(), diag::expression_unused_literal,