Merge pull request #68500 from kubamracek/embedded-crash-on-existentialmetatypeinst

[embedded] Fix compiler crash in getRuntimeEffect when processing ExistentialMetatypeInst

Author: kubamracek

lib/SIL/Utils/InstructionUtils.cpp

@@ -806,11 +806,21 @@ RuntimeEffect swift::getRuntimeEffect(SILInstruction *inst, SILType &impactType)
     case ExistentialRepresentation::Opaque:
       return RuntimeEffect::MetaData;
     case ExistentialRepresentation::Class: {
+      if (opType.isAnyObject()) {
+        if (inst->getModule().getASTContext().LangOpts.EnableObjCInterop) {
+          return RuntimeEffect::MetaData | RuntimeEffect::Existential |
+                 RuntimeEffect::ObjectiveC;
+        } else {
+          return RuntimeEffect::MetaData | RuntimeEffect::Existential;
+        }
+      }
       auto *cl = opType.getClassOrBoundGenericClass();
-      bool usesObjCModel = cl->getObjectModel() == ReferenceCounting::ObjC;
-      if ((cl && usesObjCModel) || opType.isAnyObject())
-        return RuntimeEffect::MetaData | RuntimeEffect::ObjectiveC;
-      return RuntimeEffect::MetaData | RuntimeEffect::ObjectiveC;
+      bool usesObjCModel =
+          cl && cl->getObjectModel() == ReferenceCounting::ObjC;
+      if (usesObjCModel)
+        return RuntimeEffect::MetaData | RuntimeEffect::ObjectiveC |
+               RuntimeEffect::Existential;
+      return RuntimeEffect::MetaData | RuntimeEffect::Existential;
     }
     case ExistentialRepresentation::None:
       return RuntimeEffect::NoEffect;

test/embedded/anyobject-error-no-stdlib.swift

@@ -0,0 +1,18 @@
+// RUN: %target-swift-emit-ir -parse-stdlib %s -enable-experimental-feature Embedded -verify
+
+public enum Never {}
+
+@_silgen_name("abort")
+func abort() -> Never
+
+@_semantics("typechecker.type(of:)")
+public func type<T, Metatype>(of value: T) -> Metatype { abort() }
+
+public typealias AnyObject = Builtin.AnyObject
+
+precedencegroup AssignmentPrecedence { assignment: true }
+
+public func foo(_ x: AnyObject) {
+  _ = type(of: x) // expected-error {{existential can cause metadata allocation or locks}}
+  // expected-note@-1 {{called from here}}
+}