[Android] Add testing support

This adds support for running tests for the stdlib built
for Android, both on the host machine and on an Android device.

The Android variant of Swift may be built and tested using
the following `build-script` invocation:

```
$ utils/build-script \
  -R \                                           # Build in ReleaseAssert mode.
  -T \                                           # Run all tests.
  --android \                                    # Build for Android.
  --android-deploy-device-path /data/local/tmp \ # Temporary directory on the device where Android tests are run.
  --android-ndk ~/android-ndk-r10e \             # Path to an Android NDK.
  --android-ndk-version 21 \
  --android-icu-uc ~/libicu-android/armeabi-v7a/libicuuc.so \
  --android-icu-uc-include ~/libicu-android/armeabi-v7a/icu/source/common \
  --android-icu-i18n ~/libicu-android/armeabi-v7a/libicui18n.so \
  --android-icu-i18n-include ~/libicu-android/armeabi-v7a/icu/source/i18n/
```

See docs/Testing.rst for more details.

Author: modocache

docs/Testing.rst

@@ -134,6 +134,48 @@ targets mentioned above and modify it as necessary. lit.py also has several
 useful features, like timing tests and providing a timeout. Check these features
 out with ``lit.py -h``.
 
+Running tests hosted on an Android device
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+You may run tests targeting android-armv7 by connecting a device to run the
+tests on, then pushing the necessary dependencies to that device.
+
+1. Connect your Android device to your computer via USB. Ensure that remote
+   debugging is enabled for that device by following the official instructions:
+   https://developer.chrome.com/devtools/docs/remote-debugging.
+2. Confirm the device is connected by running ``adb devices``. You should see
+   your device listed.
+3. Push the built products for android-armv7 to your device, using the
+   ``utils/android/adb_push_built_products.py`` script. For example, to push
+   the built products at a build directory
+   ``~/swift/Ninja-ReleaseAssert/swift-linux-x86_64``, with an Android NDK
+   placed at ``~/android-ndk-r10e``, run the following:
+
+       $ utils/android/adb_push_built_products.py \
+             ~/swift/build/Ninja-ReleaseAssert/swift-linux-x86_64/lib/swift/android/ \
+             --ndk ~/android-ndk-r10e
+4. Run the test suite for the ``android-armv7`` target.
+
+You may run the tests using the build script as well. Specifying a
+``--android-deploy-device-path`` pushes the built Android products to your
+device as part of the build:
+
+    $ utils/build-script \
+      -R \                                           # Build in ReleaseAssert mode.
+      -T \                                           # Run all tests.
+      --android \                                    # Build for Android.
+      --android-deploy-device-path /data/local/tmp \ # Temporary directory on the device where Android tests are run.
+      --android-ndk ~/android-ndk-r10e \             # Path to an Android NDK.
+      --android-ndk-version 21 \
+      --android-icu-uc ~/libicu-android/armeabi-v7a/libicuuc.so \
+      --android-icu-uc-include ~/libicu-android/armeabi-v7a/icu/source/common \
+      --android-icu-i18n ~/libicu-android/armeabi-v7a/libicui18n.so \
+      --android-icu-i18n-include ~/libicu-android/armeabi-v7a/icu/source/i18n/
+
+You must run the Linux tests once in order to build the Android test suite.
+After that, you may run the above command with the ``--skip-test-linux`` option
+to only run Android tests.
+
 Writing tests
 -------------
 

stdlib/private/SwiftPrivateLibcExtras/Subprocess.swift

@@ -136,6 +136,8 @@ public func spawnChild(_ args: [String])
 
     // Close the pipe when we're done writing the error.
     close(childToParentPipe.writeFD)
+  } else if pid > 0 {
+    close(childToParentPipe.writeFD)
   }
 #else
   var fileActions = _make_posix_spawn_file_actions_t()

test/1_stdlib/InputStream.swift.gyb

@@ -16,6 +16,9 @@
 // RUN: %S/../../utils/line-directive %t/InputStream.swift -- %target-run %t/a.out
 // REQUIRES: executable_test
 
+// FIXME: This test takes too long to complete on Android.
+// UNSUPPORTED: OS=linux-androideabi
+
 import StdlibUnittest
 
 

test/1_stdlib/POSIX.swift

@@ -1,6 +1,10 @@
 // RUN: %target-run-simple-swift
 // REQUIRES: executable_test
 
+// Android Bionic does not provide a working implementation of
+// <semaphore.h>.
+// XFAIL: OS=linux-androideabi
+
 import StdlibUnittest
 #if os(Linux)
   import Glibc

test/ClangModules/autolinking.swift

@@ -16,6 +16,7 @@
 // UNSUPPORTED: OS=linux-gnu
 // UNSUPPORTED: OS=linux-gnueabihf
 // UNSUPPORTED: OS=freebsd
+// UNSUPPORTED: OS=linux-androideabi
 
 import LinkMusket
 import LinkFramework

test/IRGen/c_layout.sil

@@ -1,4 +1,6 @@
-// RUN: %target-swift-frontend -I %S/Inputs/abi %s -emit-ir | FileCheck %s --check-prefix=CHECK-%target-cpu
+// FIXME: Rather than passing `-fsigned-char`, this should test each platform's expected char
+//        signedness. For Android, this means implicitly unsigned. See: https://github.com/apple/swift/pull/1103
+// RUN: %target-swift-frontend -Xcc -fsigned-char -I %S/Inputs/abi %s -emit-ir | FileCheck %s --check-prefix=CHECK-%target-cpu
 
 sil_stage canonical
 import c_layout

test/Serialization/autolinking.swift

@@ -25,6 +25,7 @@
 // UNSUPPORTED: OS=linux-gnu
 // UNSUPPORTED: OS=linux-gnueabihf
 // UNSUPPORTED: OS=freebsd
+// UNSUPPORTED: OS=linux-androideabi
 
 import someModule
 

test/lit.cfg

@@ -719,6 +719,7 @@ elif run_os == 'linux-gnu' or run_os == 'linux-gnueabihf' or run_os == 'freebsd'
             '%s -Xfrontend -disable-access-control %%s' % (target_run_base))
         config.available_features.add('interpret')
         config.environment['SWIFT_INTERPRETER'] = config.swift
+    # FIXME: Include -sdk in this invocation.
     config.target_sil_opt = (
         '%s -target %s %s %s' %
         (config.sil_opt, config.variant_triple, resource_dir_opt, mcp_opt))
@@ -740,6 +741,62 @@ elif run_os == 'linux-gnu' or run_os == 'linux-gnueabihf' or run_os == 'freebsd'
     config.target_ld = (
         "ld -L%s" %
         (os.path.join(test_resource_dir, config.target_sdk_name)))
+elif run_os == 'linux-androideabi':
+    lit_config.note("Testing Android " + config.variant_triple)
+    config.target_object_format = "elf"
+    config.target_dylib_extension = "so"
+    config.target_runtime = "native"
+    config.target_swift_autolink_extract = inferSwiftBinary("swift-autolink-extract")
+    config.target_sdk_name = "android"
+    android_linker_opt = "-L {libcxx} -L {libgcc}".format(
+        libcxx=os.path.join(config.android_ndk_path,
+                            "sources", "cxx-stl", "llvm-libc++", "libs",
+                            "armeabi-v7a"),
+        libgcc=os.path.join(config.android_ndk_path,
+                            "toolchains",
+                            "arm-linux-androideabi-{}".format(
+                                config.android_ndk_gcc_version),
+                            "prebuilt", "linux-x86_64", "lib", "gcc",
+                            "arm-linux-androideabi",
+                            config.android_ndk_gcc_version))
+    config.target_build_swift = (
+        '%s -target %s -sdk %s %s -Xlinker -pie %s %s %s %s'
+        % (config.swiftc, config.variant_triple, config.variant_sdk,
+           android_linker_opt, resource_dir_opt, mcp_opt,
+           config.swift_test_options, swift_execution_tests_extra_flags))
+    config.target_swift_frontend = (
+        '%s -frontend -target %s -sdk %s %s %s'
+        % (config.swift, config.variant_triple, config.variant_sdk,
+           android_linker_opt, resource_dir_opt))
+    subst_target_swift_frontend_mock_sdk = config.target_swift_frontend
+    subst_target_swift_frontend_mock_sdk_after = ""
+    config.target_run = os.path.join(
+        config.swift_src_root, 'utils', 'android', 'adb_test_runner.py')
+    # FIXME: Include -sdk in this invocation.
+    config.target_sil_opt = (
+        '%s -target %s %s %s' %
+        (config.sil_opt, config.variant_triple, resource_dir_opt, mcp_opt))
+    config.target_swift_ide_test = (
+        '%s -target %s %s %s %s' %
+        (config.swift_ide_test, config.variant_triple, resource_dir_opt,
+         mcp_opt, ccp_opt))
+    subst_target_swift_ide_test_mock_sdk = config.target_swift_ide_test
+    subst_target_swift_ide_test_mock_sdk_after = ""
+    config.target_swiftc_driver = (
+        "%s -target %s -sdk %s %s %s %s" %
+        (config.swiftc, config.variant_triple, config.variant_sdk,
+         android_linker_opt, resource_dir_opt, mcp_opt))
+    config.target_swift_modulewrap = (
+        '%s -modulewrap -target %s' %
+        (config.swiftc, config.variant_triple))
+    config.target_clang = (
+        "clang++ -target %s %s" %
+        (config.variant_triple, clang_mcp_opt))
+    config.target_ld = (
+        "ld -L%s" %
+        (os.path.join(test_resource_dir, config.target_sdk_name)))
+    # The Swift interpreter is not available when targeting Android.
+    config.available_features.remove('swift_interpreter')
 
 else:
     lit_config.fatal("Don't know how to define target_run and "

test/lit.site.cfg.in

@@ -18,6 +18,8 @@ config.variant_sdk = "@VARIANT_SDK@"
 config.variant_suffix = "@VARIANT_SUFFIX@"
 config.swiftlib_dir = "@LIT_SWIFTLIB_DIR@"
 config.darwin_xcrun_toolchain = "@SWIFT_DARWIN_XCRUN_TOOLCHAIN@"
+config.android_ndk_path = "@SWIFT_ANDROID_NDK_PATH@"
+config.android_ndk_gcc_version = "@SWIFT_ANDROID_NDK_GCC_VERSION@"
 
 config.coverage_mode = "@SWIFT_ANALYZE_CODE_COVERAGE@"