Merge pull request #36701 from aschwaighofer/rdar_76009728

IRGen: Fix async throw emission for indirect direct values

Author: aschwaighofer

lib/IRGen/GenCall.cpp

@@ -4803,12 +4803,13 @@ void irgen::emitAsyncReturn(IRGenFunction &IGF, AsyncContextLayout &asyncLayout,
   auto &nativeSchema =
       IGM.getTypeInfo(funcResultTypeInContext).nativeReturnValueSchema(IGM);
   if (result.empty() && !nativeSchema.empty()) {
-    // When we throw, we set the return values to undef.
-    nativeSchema.enumerateComponents([&](clang::CharUnits begin,
-                                         clang::CharUnits end,
-                                         llvm::Type *componentTy) {
-      nativeResultsStorage.push_back(llvm::UndefValue::get(componentTy));
-    });
+    if (!nativeSchema.requiresIndirect())
+      // When we throw, we set the return values to undef.
+      nativeSchema.enumerateComponents([&](clang::CharUnits begin,
+                                           clang::CharUnits end,
+                                           llvm::Type *componentTy) {
+        nativeResultsStorage.push_back(llvm::UndefValue::get(componentTy));
+      });
     if (!error.empty())
       nativeResultsStorage.push_back(error.claimNext());
     nativeResults = nativeResultsStorage;

test/IRGen/async/throwing.swift

@@ -130,6 +130,15 @@ func testSyncDoesntThrowThenAsyncDoesntThrow() async throws -> (Int, Int) {
   return (sync, async)
 }
 
+public enum MyError : Error {
+    case a
+}
+
+// We used to crash on this.
+public func throwLarge() async throws -> (Int, Int, Int, Int, Int, Int, Int, Int) {
+    throw MyError.a
+}
+
 // CHECK: E()
 // CHECK: E()
 // CHECK: E()