[TempRValueOpt] NFC: Assert no copy of uncopyable.

Author: nate-chandler

lib/SILOptimizer/Transforms/TempRValueElimination.cpp

@@ -616,11 +616,17 @@ void TempRValueOptPass::tryOptimizeCopyIntoTemp(CopyAddrInst *copyInst) {
     if (lastLoadInst == copyInst)
       return true;
     if (auto *cai = dyn_cast<CopyAddrInst>(lastLoadInst)) {
-      return cai->getSrc() != tempObj || !cai->isTakeOfSrc();
+      auto retval = cai->getSrc() != tempObj || !cai->isTakeOfSrc();
+      assert(!tempObj->getType().isMoveOnly() ||
+             !retval && "introducing copy of move-only value!?");
+      return retval;
     }
     if (auto *li = dyn_cast<LoadInst>(lastLoadInst)) {
-      return li->getOperand() != tempObj ||
-             li->getOwnershipQualifier() != LoadOwnershipQualifier::Take;
+      auto retval = li->getOperand() != tempObj ||
+                    li->getOwnershipQualifier() != LoadOwnershipQualifier::Take;
+      assert(!tempObj->getType().isMoveOnly() ||
+             !retval && "introducing copy of move-only value!?");
+      return retval;
     }
     return true;
   }();

test/SILOptimizer/temp_rvalue_opt_ossa.sil

@@ -50,6 +50,7 @@ sil @unknown : $@convention(thin) () -> ()
 sil [ossa] @guaranteed_user : $@convention(thin) (@guaranteed Klass) -> ()
 sil [ossa] @guaranteed_user_with_result : $@convention(thin) (@guaranteed Klass) -> @out Klass
 sil [ossa] @inguaranteed_user_without_result_NTS : $@convention(thin) (@in_guaranteed NonTrivialStruct) -> ()
+sil [ossa] @inguaranteed_user_without_result_MOS : $@convention(thin) (@in_guaranteed MOS) -> ()
 
 sil [ossa] @inguaranteed_user_without_result : $@convention(thin) (@in_guaranteed Klass) -> () {
 bb0(%0 : $*Klass):
@@ -1686,6 +1687,34 @@ entry(%out : $*Klass):
   return %retval : $()
 }
 
+// CHECK-LABEL: sil [ossa] @take_from_original_copy_addr__final_use_apply__move_only : {{.*}} {
+// CHECK:         [[GET:%[^,]+]] = function_ref @getMOS
+// CHECK:         [[USER:%[^,]+]] = function_ref @inguaranteed_user_without_result_MOS
+// CHECK:         [[INSTANCE:%[^,]+]] = apply [[GET]]()
+// CHECK:         [[SRC:%[^,]+]] = alloc_stack $MOS
+// CHECK:         store [[INSTANCE]] to [init] [[SRC]]
+// CHECK:         apply [[USER]]([[SRC]])
+// CHECK:         apply [[USER]]([[SRC]])
+// CHECK:         destroy_addr [[SRC]]
+// CHECK:         dealloc_stack [[SRC]]
+// CHECK-LABEL: } // end sil function 'take_from_original_copy_addr__final_use_apply__move_only'
+sil [ossa] @take_from_original_copy_addr__final_use_apply__move_only : $() -> () {
+  %getMOS = function_ref @getMOS : $@convention(thin) () -> @owned MOS
+  %user = function_ref @inguaranteed_user_without_result_MOS : $@convention(thin) (@in_guaranteed MOS) -> ()
+  %instance_1 = apply %getMOS() : $@convention(thin) () -> @owned MOS
+  %src = alloc_stack $MOS
+  store %instance_1 to [init] %src : $*MOS
+  apply %user(%src) : $@convention(thin) (@in_guaranteed MOS) -> ()
+  %tmp = alloc_stack $MOS
+  copy_addr [take] %src to [init] %tmp : $*MOS
+  apply %user(%tmp) : $@convention(thin) (@in_guaranteed MOS) -> ()
+  destroy_addr %tmp : $*MOS
+  dealloc_stack %tmp : $*MOS
+  dealloc_stack %src : $*MOS
+  %tuple = tuple ()
+  return %tuple : $()
+}
+
 // This does not get optimized correctly because of the conservative treatment of load_borrow/end_borrow in MemBehavior
 // CHECK-LABEL: sil [ossa] @test_temprvoborrowboundary1 :
 // CHECK: copy_addr