Merge pull request #1081 from practicalswift/unnecessary-list-comprehensions

[gardening] Avoid unnecessary list comprehensions

Author: gribozavr

utils/GYBUnicodeDataUtils.py

@@ -407,13 +407,13 @@ def serialize(self, unicode_property):
         self.supp_lookup2_bytes_per_entry = 1 if len(self.supp_data) < 256 else 2
         self.supp_data_bytes_per_entry = 1
 
-        BMP_lookup_words = [elt for elt in self.BMP_lookup]
+        BMP_lookup_words = list(self.BMP_lookup)
         BMP_data_words = [
             unicode_property.to_numeric_value(elt)
             for block in self.BMP_data
             for elt in block]
 
-        supp_lookup1_words = [elt for elt in self.supp_lookup1]
+        supp_lookup1_words = list(self.supp_lookup1)
         supp_lookup2_words = [elt for block in self.supp_lookup2 for elt in block]
         supp_data_words = [
             unicode_property.to_numeric_value(elt)

utils/name-compression/CBCGen.py

@@ -105,7 +105,7 @@ def addLine(line):
 # notice that Y and J are missing because they are escape chars:
 charset = r"0123456789_abcdefghijklmnopqrstuvwxyzABCDEFGHIKLMNOPQRSTUVWXZ$"
 # alphabet without the escape chars.
-encoders = [c for c in charset]
+encoders = list(charset)
 enc_len = len(encoders)
 
 # Take the most frequent entries from the table that fit into the range of

utils/pass-pipeline/scripts/pipeline_generator.py

@@ -12,7 +12,7 @@
 import pass_pipeline_library
 import passes
 
-normal_pipeline = [x for x in pass_pipeline_library.normal_passpipelines()]
+normal_pipeline = list(pass_pipeline_library.normal_passpipelines())
 pass_pipelines = [x.identifier for x in normal_pipeline]
 
 parser = argparse.ArgumentParser(description=textwrap.dedent("""

utils/pre-commit-benchmark

@@ -222,7 +222,7 @@ def compareTimingsFiles(file1, file2):
     scores1, runs1 = getScores(file1)
     scores2, runs2 = getScores(file2)
     runs = min(runs1, runs2)
-    keys = [f for f in set(scores1.keys() + scores2.keys())]
+    keys = list(set(scores1.keys() + scores2.keys()))
     if VERBOSE:
         print(scores1)
         print(scores2)