[stdlib] Eliminate _AnyHashableBox._asSet() & ._asDictionary()

_canonicalBox can perform essentially the same job, so there is no reason to have these requirements.

Author: lorentey

stdlib/public/core/AnyHashable.swift

@@ -54,21 +54,12 @@ internal protocol _AnyHashableBox {
   var _base: Any { get }
   func _unbox<T: Hashable>() -> T?
   func _downCastConditional<T>(into result: UnsafeMutablePointer<T>) -> Bool
-
-  func _asSet() -> Set<AnyHashable>?
-  func _asDictionary() -> Dictionary<AnyHashable, AnyHashable>?
 }
 
 extension _AnyHashableBox {
   var _canonicalBox: _AnyHashableBox {
     return self
   }
-  func _asSet() -> Set<AnyHashable>? {
-    return nil
-  }
-  func _asDictionary() -> Dictionary<AnyHashable, AnyHashable>? {
-    return nil
-  }
 }
 
 @_fixed_layout // FIXME(sil-serialize-all)

stdlib/public/core/Dictionary.swift

@@ -1541,9 +1541,17 @@ internal struct _DictionaryAnyHashableBox<Key: Hashable, Value: Hashable>
     return _value
   }
 
+  internal var _canonicalBox: _AnyHashableBox {
+    return _DictionaryAnyHashableBox<AnyHashable, AnyHashable>(_canonical)
+  }
+
   internal func _isEqual(to other: _AnyHashableBox) -> Bool? {
-    guard let other = other._asDictionary() else { return nil }
-    return _canonical == other
+    guard
+      let other = other as? _DictionaryAnyHashableBox<AnyHashable, AnyHashable>
+    else {
+      return nil
+    }
+    return _canonical == other._value
   }
 
   internal var _hashValue: Int {
@@ -1569,10 +1577,6 @@ internal struct _DictionaryAnyHashableBox<Key: Hashable, Value: Hashable>
     result.initialize(to: value)
     return true
   }
-
-  internal func _asDictionary() -> Dictionary<AnyHashable, AnyHashable>? {
-    return _canonical
-  }
 }
 
 extension Dictionary: CustomStringConvertible, CustomDebugStringConvertible {

stdlib/public/core/NewtypeWrapper.swift

@@ -96,14 +96,6 @@ where Base: _SwiftNewtypeWrapper & Hashable, Base.RawValue: Hashable {
     }
     return false
   }
-
-  func _asSet() -> Set<AnyHashable>? {
-    return _canonicalBox._asSet()
-  }
-
-  func _asDictionary() -> Dictionary<AnyHashable, AnyHashable>? {
-    return _canonicalBox._asDictionary()
-  }
 }
 
 #if _runtime(_ObjC)

stdlib/public/core/Set.swift

@@ -522,9 +522,15 @@ internal struct _SetAnyHashableBox<Element: Hashable>: _AnyHashableBox {
     return _value
   }
 
+  internal var _canonicalBox: _AnyHashableBox {
+    return _SetAnyHashableBox<AnyHashable>(_canonical)
+  }
+
   internal func _isEqual(to other: _AnyHashableBox) -> Bool? {
-    guard let other = other._asSet() else { return nil }
-    return _canonical == other
+    guard let other = other as? _SetAnyHashableBox<AnyHashable> else {
+      return nil
+    }
+    return _canonical == other._value
   }
 
   internal var _hashValue: Int {
@@ -550,10 +556,6 @@ internal struct _SetAnyHashableBox<Element: Hashable>: _AnyHashableBox {
     result.initialize(to: value)
     return true
   }
-
-  internal func _asSet() -> Set<AnyHashable>? {
-    return _canonical
-  }
 }
 
 extension Set: SetAlgebra {