Skip to content

Commit 2d42bcc

Browse files
author
Enrico Granata
committed
There is no need for the Crawler to hold on to the name of the module, as a Crawler is only invoked when there is no real backing module to search into
Fixes rdar://24641858
1 parent 532d36d commit 2d42bcc

File tree

1 file changed

+0
-19
lines changed

1 file changed

+0
-19
lines changed

lib/IDE/ReconstructType.cpp

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -311,13 +311,6 @@ class DeclsLookupSource {
311311
}
312312
return;
313313
}
314-
else
315-
{
316-
const bool allow_crawler = false;
317-
if (!_crawler._module.empty())
318-
GetDeclsLookupSource(*ast_ctx, ConstString(_crawler._module),
319-
allow_crawler).lookupQualified(name, options, typeResolver, result);
320-
}
321314
}
322315
}
323316
else if (_type == Type::SwiftModule)
@@ -351,14 +344,6 @@ class DeclsLookupSource {
351344
}
352345
return;
353346
}
354-
else
355-
{
356-
const bool allow_crawler = false;
357-
if (!_crawler._module.empty())
358-
GetDeclsLookupSource(*ast_ctx, ConstString(_crawler._module),
359-
allow_crawler).lookupValue(path, name, kind,
360-
result);
361-
}
362347
}
363348
}
364349
else if (_type == Type::SwiftModule)
@@ -447,7 +432,6 @@ class DeclsLookupSource {
447432
break;
448433
case Type::Crawler:
449434
_crawler._ast = rhs._crawler._ast;
450-
_crawler._module = rhs._crawler._module;
451435
break;
452436
case Type::SwiftModule:
453437
_module = rhs._module;
@@ -476,7 +460,6 @@ class DeclsLookupSource {
476460
break;
477461
case Type::Crawler:
478462
_crawler._ast = rhs._crawler._ast;
479-
_crawler._module = rhs._crawler._module;
480463
break;
481464
case Type::SwiftModule:
482465
_module = rhs._module;
@@ -561,7 +544,6 @@ class DeclsLookupSource {
561544
swift::ModuleDecl *_module;
562545
struct {
563546
swift::ASTContext* _ast;
564-
std::string _module;
565547
} _crawler;
566548
swift::NominalTypeDecl *_decl;
567549
struct {
@@ -588,7 +570,6 @@ class DeclsLookupSource {
588570
if (_a)
589571
{
590572
_crawler._ast = _a;
591-
_crawler._module = _m.data();
592573
_type = Type::Crawler;
593574
}
594575
else

0 commit comments

Comments
 (0)