add missing APIs for TaskGroup and cleanup

Author: ktoso

include/swift/Basic/Features.def

@@ -87,7 +87,8 @@ LANGUAGE_FEATURE(BuiltinBuildTaskExecutor, 0, "TaskExecutor-building builtins",
 LANGUAGE_FEATURE(BuiltinBuildExecutor, 0, "Executor-building builtins", true)
 LANGUAGE_FEATURE(BuiltinBuildComplexEqualityExecutor, 0, "Executor-building for 'complexEquality executor' builtins", true)
 LANGUAGE_FEATURE(BuiltinBuildMainExecutor, 0, "MainActor executor building builtin", true)
-LANGUAGE_FEATURE(BuiltinCreateAsyncTaskInGroup, 0, "Task create builtin with extra flags", true)
+LANGUAGE_FEATURE(BuiltinCreateAsyncTaskInGroup, 0, "Task create in task group builtin with extra flags", true)
+LANGUAGE_FEATURE(BuiltinCreateAsyncTaskInGroupWithExecutor, 0, "Task create in task group builtin with extra flags", true)
 LANGUAGE_FEATURE(BuiltinCreateAsyncTaskWithExecutor, 0, "Task create builtin with extra executor preference", true)
 LANGUAGE_FEATURE(BuiltinCopy, 0, "Builtin.copy()", true)
 LANGUAGE_FEATURE(BuiltinStackAlloc, 0, "Builtin.stackAlloc", true)

lib/AST/ASTPrinter.cpp

@@ -3145,6 +3145,10 @@ static bool usesFeatureBuiltinCreateAsyncTaskInGroup(Decl *decl) {
   return false;
 }
 
+static bool usesFeatureBuiltinCreateAsyncTaskInGroupWithExecutor(Decl *decl) {
+  return false;
+}
+
 static bool usesFeatureBuiltinCreateAsyncTaskWithExecutor(Decl *decl) {
   return false;
 }

lib/IRGen/GenCall.cpp

@@ -4560,8 +4560,6 @@ llvm::Value *irgen::emitTaskCreate(
     llvm::Value *taskOptions = llvm::ConstantInt::get(
       IGF.IGM.SwiftTaskOptionRecordPtrTy, 0);
 
-  // If there is a task group, emit a task group option structure to contain
-  // it.
   // If there is a task group, emit a task group option structure to contain it.
   if (taskGroup) {
     TaskOptionRecordFlags optionsFlags(TaskOptionRecordKind::TaskGroup);
@@ -4587,14 +4585,6 @@ llvm::Value *irgen::emitTaskCreate(
     IGF.Builder.CreateStore(
         taskGroup, IGF.Builder.CreateStructGEP(optionsRecord, 1, Size()));
 
-//    if (executorIdentity) {
-//      auto executorRecord = IGF.Builder.CreateStructGEP(optionsRecord, 1, Size());
-//      IGF.Builder.CreateStore(
-//          executorIdentity, IGF.Builder.CreateStructGEP(executorRecord, 0, Size()));
-//      IGF.Builder.CreateStore(
-//          executorImpl, IGF.Builder.CreateStructGEP(executorRecord, 1, Size()));
-//    }
-
     taskOptions = IGF.Builder.CreateBitOrPointerCast(
         optionsRecord.getAddress(), IGF.IGM.SwiftTaskOptionRecordPtrTy);
   }