[Macros] Add API for expanding a macro defined in terms of another macro #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please test |
Split the API for macro definition checking and expansion into two distinct parts: a definition-checking operation that can fail (producing error diagnostics) and an expansion operation that cannot fail (for expansion). This better matches the structure that clients (i.e., the compiler) should use.
We are likely to grow more of these utilities, and they might eventually be sunk down into a common library, so keep the factored out.
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test Windows |
Member
Author
|
I'm holding off on merging this until I have the compiler side of it implemented, to make sure we have the right API here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce APIs to help with expanding a macro that is defined in terms of another macro, e.g.,
There are effectively two new APIs:
MacroDeclSyntax.checkDefinition()checks that the definition of a macro is well-formed, producing a semantic representation suitable for expansion when it is, or produces error diagnostics when it isn't.MacroDeclSyntax.expandwhich takes that semantic representation and a (well-formed) argument list or syntax node and performs the actual expansion.