Merge pull request #1544 from ahoppen/ahoppen/remove-swiftsyntaxparser

Remove SwiftSyntaxParser module

Author: ahoppen

BUILD.bazel

@@ -95,14 +95,6 @@ swift_syntax_library(
     ],
 )
 
-swift_syntax_library(
-    name = "SwiftSyntaxParser",
-    deps = [
-        ":SwiftParser",
-        ":SwiftSyntax",
-    ],
-)
-
 swift_syntax_library(
     name = "SwiftRefactor",
     deps = [

CONTRIBUTING.md

@@ -43,11 +43,7 @@ If you can’t find it in your Schemes, you need to manually add it using Produc
 
 ### XCTests
 
-The `SwiftSyntaxParser` module (the legacy parser) of this repository depends on the C++ parser library (`_InternalSwiftSyntaxParser.dylib`) to parse source code.
-The syntax node definitions of that parser library need to match those used by your SwiftSyntax checkout.
-Most of the time, the parser library included in the latest Swift Development Snapshot will fulfill this requirement. 
-
-To run the tests in Xcode, select the latest Swift Development Snapshot in Xcode -> Toolchains, select the SwiftSyntax-Package scheme and hit Product -> Test.
+To run the tests in Xcode, select the SwiftSyntax-Package scheme and hit Product -> Test.
 
 You can also run the tests from the command line using
 ```bash
@@ -68,7 +64,7 @@ Tip: Running SwiftSyntax’s self-parse tests takes the majority of testing time
 
 ### `lit`-based tests
 
-A few tests of the `SwiftSyntaxParser` module (the legacy parser), which test the interaction between SwiftSyntax and the C++ parser library (`_InternalSwiftSyntaxParser.dylib`) are based LLVM’s `lit` and `FileCheck` tools.
+A few tests are based LLVM’s `lit` and `FileCheck` tools.
 To run these, build `FileCheck`, e.g. by building the Swift compiler and run the tests using the following command:
 ```bash
 ./build-script.py test --toolchain /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-<recent date>.xctoolchain/usr --skip-lit-tests --filecheck-exec /path/to/build/Release+Asserts/llvm-macosx-x86_64/bin/FileCheck

Package.swift

@@ -56,7 +56,6 @@ let package = Package(
     .library(name: "SwiftSyntax", type: .static, targets: ["SwiftSyntax"]),
     .library(name: "SwiftSyntaxBuilder", type: .static, targets: ["SwiftSyntaxBuilder"]),
     .library(name: "SwiftSyntaxMacros", type: .static, targets: ["SwiftSyntaxMacros"]),
-    .library(name: "SwiftSyntaxParser", type: .static, targets: ["SwiftSyntaxParser"]),
   ],
   targets: [
     // MARK: - Internal helper targets
@@ -70,6 +69,11 @@ let package = Package(
       dependencies: ["SwiftBasicFormat", "SwiftSyntax", "SwiftSyntaxBuilder"]
     ),
 
+    .testTarget(
+      name: "SwiftSyntaxTestSupportTest",
+      dependencies: ["_SwiftSyntaxTestSupport", "SwiftParser"]
+    ),
+
     // MARK: - Library targets
     // Formatting style:
     //  - One section for each target and its test target
@@ -246,29 +250,15 @@ let package = Package(
 
     .executableTarget(
       name: "lit-test-helper",
-      dependencies: ["IDEUtils", "SwiftSyntax", "SwiftSyntaxParser"]
+      dependencies: ["IDEUtils", "SwiftSyntax", "SwiftParser"]
     ),
 
     // MARK: PerformanceTest
     // TODO: Should be included in SwiftParserTest/SwiftSyntaxTest
 
     .testTarget(
       name: "PerformanceTest",
-      dependencies: ["IDEUtils", "SwiftParser", "SwiftSyntax", "SwiftSyntaxParser"],
-      exclude: ["Inputs"]
-    ),
-
-    // MARK: SwiftSyntaxParser
-    // TODO: All clients should use SwiftParser instead
-
-    .target(
-      name: "SwiftSyntaxParser",
-      dependencies: ["SwiftSyntax", "SwiftParser"]
-    ),
-
-    .testTarget(
-      name: "SwiftSyntaxParserTest",
-      dependencies: ["_SwiftSyntaxTestSupport", "SwiftSyntaxParser"],
+      dependencies: ["IDEUtils", "SwiftParser", "SwiftSyntax"],
       exclude: ["Inputs"]
     ),
   ]

Sources/SwiftParser/README.md

@@ -1,7 +1,6 @@
 ## Overview
 
-The `SwiftParser` framework implements a parser that accepts Swift source text
-as input and produces a SwiftSyntax syntax tree. This module is under active development and is not yet ready to completely replace `SwiftSyntaxParser`. For more information about the design of this module, please see [the module documentation](SwiftParser.docc/SwiftParser.md).
+The `SwiftParser` framework implements a parser that accepts Swift source text as input and produces a SwiftSyntax syntax tree. 
 
 ## Quickstart
 

Sources/SwiftParser/SwiftParser.docc/SwiftParser.md

@@ -4,8 +4,7 @@ A parser for the Swift programming language.
 
 ## Overview
 
-The `SwiftParser` framework implements a parser that accepts Swift source text
-as input and produces a SwiftSyntax syntax tree. This module is under active development and is not yet ready to completely replace `SwiftSyntaxParser`.
+The `SwiftParser` framework implements a parser that accepts Swift source text as input and produces a SwiftSyntax syntax tree. 
 
 ## Quickstart