Skip to content

Commit dfd4217

Browse files
[PubgrubTests] append, not assign, packageDependencies to value in dictionary keyed by product
`dependencies` passed to `DependencyGraphBuilder.serve` can have duplicate product keys, so when `dependencies` are iterated, the same `product` can appear more than once, each time with possibly different `filteredDependencies`. Assigning `packageDependencies` mapped from a `product`'s `filteredDependencies` to the value in a different dictionary keyed by the same `product` overrides any existing value from a previous assignment. Appending `packageDependencies` instead preserves all previous values.
1 parent ac3ebf2 commit dfd4217

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Tests/PackageGraphTests/PubgrubTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2193,7 +2193,7 @@ class DependencyGraphBuilder {
21932193
let packageDependencies: [MockContainer.Dependency] = filteredDependencies.map {
21942194
(container: reference(for: $0), requirement: $1.0, products: $1.1)
21952195
}
2196-
container.dependencies[version.description, default: [:]][product] = packageDependencies
2196+
container.dependencies[version.description, default: [:]][product, default: []] += packageDependencies
21972197
}
21982198
self.containers[package] = container
21992199
}

0 commit comments

Comments
 (0)