Skip to content

Commit 53d26bd

Browse files
committed
Filter codesign messages
Right now we end up with this output on relink: ``` /Users/neonacho/Projects/public/swift-package-manager/.build/arm64-apple-macosx/debug/swift-bootstrap: replacing existing signature ``` This change specifically filters any output from `codesign` commands which haven't failed and we aren't in verbose mode. This should eventually be possible at the command level, but for the time being this allows us to avoid shipping SwiftPM with this messy output. rdar://118937939
1 parent e5dbd8d commit 53d26bd

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Sources/Build/BuildOperationBuildSystemDelegateHandler.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -826,8 +826,10 @@ final class BuildOperationBuildSystemDelegateHandler: LLBuildBuildSystemDelegate
826826
process: ProcessHandle,
827827
result: CommandExtendedResult
828828
) {
829+
// FIXME: This should really happen at the command-level and is just a stopgap measure.
830+
let shouldFilterOutput = !self.logLevel.isVerbose && command.verboseDescription.components(separatedBy: " ").first == "codesign" && result.result != .failed
829831
queue.async {
830-
if let buffer = self.nonSwiftMessageBuffers[command.name] {
832+
if let buffer = self.nonSwiftMessageBuffers[command.name], !shouldFilterOutput {
831833
self.progressAnimation.clear()
832834
self.outputStream.send(buffer)
833835
self.outputStream.flush()

0 commit comments

Comments
 (0)