From 91bfdd8aa65a96e144d57e3b16670ffa4970969e Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Wed, 28 Dec 2022 08:41:31 -0800 Subject: [PATCH] libllbuild: correct the macro usage for DLL builds `_DLL` indicates that the MSVCRT version is the shared form rather than static. This corresponds to `/MD` (and the lack to `/MT`). `_WINDLL` is used to indicate that we are building statically or dynamically. This change is required to experiment with static builds of libllbuild with CMake. --- products/libllbuild/include/llbuild/llbuild-defines.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/products/libllbuild/include/llbuild/llbuild-defines.h b/products/libllbuild/include/llbuild/llbuild-defines.h index b2d95655..c8f51674 100644 --- a/products/libllbuild/include/llbuild/llbuild-defines.h +++ b/products/libllbuild/include/llbuild/llbuild-defines.h @@ -31,7 +31,7 @@ #define LLBUILD_EXPORT LLBUILD_EXTERN __attribute__((__visibility__("default"))) #else // asume PE/COFF -#if defined(_DLL) +#if defined(_WINDLL) #if defined(libllbuild_EXPORTS) #define LLBUILD_EXPORT LLBUILD_EXTERN __declspec(dllexport) #else