Enable FoundationMacrosTests on Windows #1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
parkera
approved these changes
Jul 14, 2025
compnerd
approved these changes
Jul 15, 2025
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
If it builds, why not. However, I'd be curious to know how this was "fixed" (/alternatename: doesn't give the desired behaviour AFAIK).
Contributor
Author
@daveinglis mentioned that it was fixed by swiftlang/swift-package-manager#8515. I was expecting this to fix the more general problem with test targets that depend on an executable, but I think macro tests are just a specific type of target in this category so I figured I'd give re-enabling this a shot and it looks like it builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent main/6.2 snapshots (since ~early May) SwiftPM now supports building targets that depend on executables (like macro tests which depend on the macro executable) like we do on Linux and macOS. Now that this limitation has been resolved, we can enable our macro tests on Windows