Add -package-name to driver #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
Contributor
|
@elsh could you please update This should bring in |
Contributor
|
Oh and this repo does not have a smoke test, just |
Contributor
Author
|
@swift-ci test |
artemcm
approved these changes
Feb 7, 2023
nkcsgexi
approved these changes
Feb 7, 2023
Contributor
Author
|
@swift-ci test macOS |
1 similar comment
Contributor
Author
|
@swift-ci test macOS |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test macOS |
Contributor
Author
|
@swift-ci test |
xymus
reviewed
Feb 8, 2023
xymus
approved these changes
Feb 8, 2023
Contributor
xymus
left a comment
xymus
left a comment
There was a problem hiding this comment.
I think it's worth removing the warning when not using package at all. Otherwise this looks good!
Add packageName to ModuleOutputInfo Add package name validation and diagnostics
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test macOS |
1 similar comment
Contributor
Author
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -package-name to driver
Add name validation and diagnostics
Resolves rdar://105119573.