From e70f99d571ce637f092e4e39c1ae32c7d79e0d19 Mon Sep 17 00:00:00 2001 From: Kyle Date: Tue, 14 Jun 2022 18:09:02 +0800 Subject: [PATCH 1/3] Add Github CHERRY_PICK pull request template --- .github/PULL_REQUEST_TEMPLATE/CHERRY_PICK.md | 11 +++++++++++ .../DEFAULT.md} | 0 2 files changed, 11 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE/CHERRY_PICK.md rename .github/{pull_request_template.md => PULL_REQUEST_TEMPLATE/DEFAULT.md} (100%) diff --git a/.github/PULL_REQUEST_TEMPLATE/CHERRY_PICK.md b/.github/PULL_REQUEST_TEMPLATE/CHERRY_PICK.md new file mode 100644 index 0000000000..30f7258b15 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/CHERRY_PICK.md @@ -0,0 +1,11 @@ +- **Explanation**: _A description of the issue being fixed or enhancement being made. This can be brief, but it should be clear._ + +- **Scope**: _An assessment of the impact/importance of the change. For example, is the change a source-breaking language change, etc._ + +- **GitHub Issue**: _The issue number if the change fixes/implements an issue/enhancement on [GitHub Issues](https://github.com/apple/swift-docc/issues)._ + +- **Risk**: _What is the (specific) risk to the release for taking this change?_ + +- **Testing**: _What specific testing has been done or needs to be done to further validate any impact of this change?_ + +- **Reviewer**: _One or more code owners for the impacted components should review the change. Technical review can be delegated by a code owner or otherwise requested as deemed appropriate or useful._ \ No newline at end of file diff --git a/.github/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/DEFAULT.md similarity index 100% rename from .github/pull_request_template.md rename to .github/PULL_REQUEST_TEMPLATE/DEFAULT.md From 3097637c77c155e5766ca59c5f2b0a03501b7b74 Mon Sep 17 00:00:00 2001 From: Kyle Date: Tue, 14 Jun 2022 17:30:47 +0800 Subject: [PATCH 2/3] Update gitignore file --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 3af5306b75..973c8917bb 100644 --- a/.gitignore +++ b/.gitignore @@ -22,3 +22,4 @@ DerivedData docc-dist-build .docc-build .swiftpm +.vscode From aac77a3d55be3c5ee20bf495e503aacd23ac4dde Mon Sep 17 00:00:00 2001 From: Kyle <43724855+Kyle-Ye@users.noreply.github.com> Date: Tue, 14 Jun 2022 20:36:01 +0800 Subject: [PATCH 3/3] Remove empty lines Co-authored-by: Franklin Schrans --- .github/PULL_REQUEST_TEMPLATE/CHERRY_PICK.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/CHERRY_PICK.md b/.github/PULL_REQUEST_TEMPLATE/CHERRY_PICK.md index 30f7258b15..f12893ed69 100644 --- a/.github/PULL_REQUEST_TEMPLATE/CHERRY_PICK.md +++ b/.github/PULL_REQUEST_TEMPLATE/CHERRY_PICK.md @@ -1,11 +1,6 @@ - **Explanation**: _A description of the issue being fixed or enhancement being made. This can be brief, but it should be clear._ - - **Scope**: _An assessment of the impact/importance of the change. For example, is the change a source-breaking language change, etc._ - - **GitHub Issue**: _The issue number if the change fixes/implements an issue/enhancement on [GitHub Issues](https://github.com/apple/swift-docc/issues)._ - - **Risk**: _What is the (specific) risk to the release for taking this change?_ - - **Testing**: _What specific testing has been done or needs to be done to further validate any impact of this change?_ - - **Reviewer**: _One or more code owners for the impacted components should review the change. Technical review can be delegated by a code owner or otherwise requested as deemed appropriate or useful._ \ No newline at end of file