[Prototype] Improve link resolution for symbol links #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to improve symbol link resolution with new features and improved diagnostics. rdar://78518537
d-ronnqvist
force-pushed
the
symbol-link-resolution
branch
from
759a20f to
1d8d141
Compare
# Conflicts: # Tests/SwiftDocCTests/Infrastructure/DocumentationContext/DocumentationContextTests.swift
# Conflicts: # Sources/SwiftDocC/Infrastructure/DocumentationContext.swift
# Conflicts: # Sources/SwiftDocC/Infrastructure/DocumentationContext.swift
Contributor
Author
|
This has been very informative. These changes are well worth pursuing. That said, I don't think this PR as-is is the best way to land these changes. Rather then adding more changes to this PR I'll go through the history to break out smaller changes that can land incrementally to make preparations for running both link resolution systems side by side. I'll keep this PR open as a Draft until there's a new PR with the new link resolution system that's ready for review. |
This was referenced Jun 16, 2022
d-ronnqvist
changed the title
3 tasks
Contributor
Author
|
I'll close this prototype PR now. See #337 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://78518537
Summary
This is a draft PR that aims to improve link resolution for symbol links. The first step towards that is to allow symbol links to be redundantly disambiguated. This opens up for further changes without breaking existing links.
There is still a lot of integration work before this code can be cleaned up, documented, and optimized.
Dependencies
n/a
Testing
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded