You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// An inner function to gather problems for errors encountered during the conversion.
71
71
//
72
-
// These problems only represent unexpected thrown errors and aren't particularly user-facing but because
73
-
// `DocumentationConverter.convert(outputConsumer:)` emits them as diagnostics we do the same here.
72
+
// These problems only represent unexpected thrown errors and aren't particularly user-facing.
73
+
// For now we emit them as diagnostics because `DocumentationConverter.convert(outputConsumer:)` (which this replaced) used to do that.
74
+
//
75
+
// FIXME: In the future we could simplify this control flow by not catching these errors and turning them into diagnostics.
76
+
// Since both error-level diagnostics and thrown errors fail the documentation build,
77
+
// the only practical different this would have is that we stop on the first unexpected error instead of processing all pages and gathering all unexpected errors.
74
78
func recordProblem(from error:Swift.Error, in problems:inout[Problem], withIdentifier identifier:String){
0 commit comments