diff --git a/src/components/DocumentationTopic/TopicLinkBlockIcon.vue b/src/components/DocumentationTopic/TopicLinkBlockIcon.vue index 92cf68120..5cfa7df53 100644 --- a/src/components/DocumentationTopic/TopicLinkBlockIcon.vue +++ b/src/components/DocumentationTopic/TopicLinkBlockIcon.vue @@ -9,9 +9,8 @@ --> @@ -25,7 +24,6 @@ import TechnologyIcon from 'theme/components/Icons/TechnologyIcon.vue'; import TutorialIcon from 'theme/components/Icons/TutorialIcon.vue'; import SVGIcon from 'docc-render/components/SVGIcon.vue'; import { TopicRole } from 'docc-render/constants/roles'; -import OverridableAsset from 'docc-render/components/OverridableAsset.vue'; const TopicRoleIcons = { [TopicRole.article]: ArticleIcon, @@ -41,16 +39,12 @@ const TopicRoleIcons = { }; export default { - components: { OverridableAsset, SVGIcon }, + components: { SVGIcon }, props: { role: { type: String, required: true, }, - imageOverride: { - type: Object, - default: null, - }, }, computed: { diff --git a/src/components/DocumentationTopic/TopicsLinkBlock.vue b/src/components/DocumentationTopic/TopicsLinkBlock.vue index a3ef619fb..f790a6e91 100644 --- a/src/components/DocumentationTopic/TopicsLinkBlock.vue +++ b/src/components/DocumentationTopic/TopicsLinkBlock.vue @@ -20,7 +20,6 @@ {{ topic.title }} diff --git a/tests/unit/components/DocumentationTopic/TopicLinkBlockIcon.spec.js b/tests/unit/components/DocumentationTopic/TopicLinkBlockIcon.spec.js index d8cb6a7f9..1f0502651 100644 --- a/tests/unit/components/DocumentationTopic/TopicLinkBlockIcon.spec.js +++ b/tests/unit/components/DocumentationTopic/TopicLinkBlockIcon.spec.js @@ -13,7 +13,6 @@ import { mount } from '@vue/test-utils'; import { TopicRole } from '@/constants/roles'; import ArticleIcon from '@/components/Icons/ArticleIcon.vue'; import TechnologyIcon from '@/components/Icons/TechnologyIcon.vue'; -import OverridableAsset from '@/components/OverridableAsset.vue'; const defaultProps = { role: TopicRole.article, @@ -33,30 +32,9 @@ describe('TopicLinkBlockIcon', () => { expect(wrapper.find('.topic-icon').is(ArticleIcon)).toBe(true); }); - it('renders an override icon from an image override', () => { - const imageOverride = { - variants: [{ - url: '/foo/bar', - svgID: 'foo', - }], - }; + it('renders nothing if no role', () => { const wrapper = createWrapper({ propsData: { - imageOverride, - }, - }); - const icon = wrapper.find('.topic-icon'); - expect(icon.is(ArticleIcon)).toBe(false); - expect(icon.is(OverridableAsset)).toBe(true); - expect(icon.props()).toMatchObject({ - imageOverride, - }); - }); - - it('renders nothing if no role or image override', () => { - const wrapper = createWrapper({ - propsData: { - imageOverride: null, role: TopicRole.devLink, // no icon for this }, }); diff --git a/tests/unit/components/DocumentationTopic/TopicsLinkBlock.spec.js b/tests/unit/components/DocumentationTopic/TopicsLinkBlock.spec.js index db056b453..02c38529d 100644 --- a/tests/unit/components/DocumentationTopic/TopicsLinkBlock.spec.js +++ b/tests/unit/components/DocumentationTopic/TopicsLinkBlock.spec.js @@ -32,22 +32,13 @@ describe('TopicsLinkBlock', () => { /** @type {import('@vue/test-utils').Wrapper} */ let wrapper; - const iconOverride = { - type: 'icon', - identifier: 'icon-override', - }; - - const references = { - [iconOverride.identifier]: { foo: 'bar' }, - }; - const store = { reset: jest.fn(), setAPIChanges: jest.fn(), state: { onThisPageSections: [], apiChanges: null, - references, + references: {}, }, }; @@ -135,18 +126,6 @@ describe('TopicsLinkBlock', () => { expect(link.props('role')).toBe(propsData.topic.role); }); - it('renders a TopicLinkBlockIcon with an override', () => { - const icon = wrapper.find(TopicLinkBlockIcon); - expect(icon.props('imageOverride')).toBe(null); - wrapper.setProps({ - topic: { - ...propsData.topic, - images: [iconOverride, { type: 'card', identifier: 'foo' }], - }, - }); - expect(icon.props('imageOverride')).toBe(references[iconOverride.identifier]); - }); - it('renders a normal `WordBreak` for the link text', () => { const wordBreak = wrapper.find('.link').find(WordBreak); expect(wordBreak.exists()).toBe(true);