use table column alignments when available #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
2 tasks
dobromir-hristov
approved these changes
Sep 26, 2022
Contributor
dobromir-hristov
left a comment
dobromir-hristov
left a comment
There was a problem hiding this comment.
Looking great. Left a small comment, which may not be a problem, seeing as the snapshots have been created properly.
src/components/ContentNode.vue
Outdated
Comment on lines
130
to
133
| const cellAttrs = attrs; | ||
| const align = alignments[cellIndex] || TableColumnAlignments.unset; | ||
| if (align !== TableColumnAlignments.unset) cellAttrs.class = `${align}-cell`; | ||
| return createElement(element, { attrs: { ...cellAttrs, colspan, rowspan } }, ( |
Contributor
There was a problem hiding this comment.
I think classes have their own dedicated key they should be passed through - https://v2.vuejs.org/v2/guide/render-function.html#The-Data-Object-In-Depth
Suggested change
| const cellAttrs = attrs; | |
| const align = alignments[cellIndex] || TableColumnAlignments.unset; | |
| if (align !== TableColumnAlignments.unset) cellAttrs.class = `${align}-cell`; | |
| return createElement(element, { attrs: { ...cellAttrs, colspan, rowspan } }, ( | |
| const align = alignments[cellIndex] || TableColumnAlignments.unset; | |
| let classes = null; | |
| if (align !== TableColumnAlignments.unset) classes = `${align}-cell`; | |
| return createElement(element, { attrs: { ...attrs, colspan, rowspan }, class: classes }, ( |
Contributor
Author
There was a problem hiding this comment.
This looks nicer! I was wondering if there was a specific property for CSS classes, but i didn't dig deep enough to see it. I've pushed up this change. Thanks!
rdar://100337272
Co-authored-by: Dobromir Hristov <[email protected]>
QuietMisdreavus
force-pushed
the
table-align
branch
from
1baf42d to
661095e
Compare
Contributor
Author
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://100337272
Summary
This PR takes a new
alignmentsproperty from Render JSON and adds new styles to table cells to control their text alignments.Dependencies
swiftlang/swift-docc#389
Testing
See the testing instructions from the linked Swift-DocC PR.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded